GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix parsing of table-level CHECK constraints in CREATE TABLE by kushkrg · Pull Request #688 · phpmyadmin/sql-parser

Conversation

@kushkrg

@kushkrg kushkrg commented Nov 12, 2026

Copy link
Copy Markdown

Summary

A named table-level CHECK constraint in a CREATE TABLE statement failed to parse:

CONSTRAINT chk_next_sequence CHECK (NextSequence >= 1)

The parser reported "A symbol name was expected! A reserved keyword can not be used as a column name without backquotes" at CHECK and dropped the constraint (and everything after it) from the parsed statement. This is phpmyadmin/phpmyadmin#20572; the bug lives here because phpMyAdmin delegates parsing to this library. Unnamed table-level CHECK constraints were rejected the same way.

Changes

  • CreateDefinitions state 1 now recognises the CHECK keyword and parses [CONSTRAINT [symbol]] CHECK (expr) [[NOT] ENFORCED] with the existing field options, the same way a column-level CHECK is parsed in state 3.
  • Definitions that carry options but neither a data type nor a key (exactly the CHECK constraint shape) are no longer dropped when the definition list is flushed.
  • New parser test data parseCreateTableWithCheckConstraint using the statement from the original report, registered in CreateStatementTest.

Verified locally: the reported statement now parses with no errors and builds back with both constraints; the full test suite passes (1025 tests, 4120 assertions).

Fixes phpmyadmin/phpmyadmin#20572

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kushkrg
Fix parsing of table-level CHECK constraints in CREATE TABLE
3cb20c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: the CHECK keyword creates syntax error since last week

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@kushkrg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.