GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Fix MOVED recovery when the previous master has no replicas by ebubekiryigit · Pull Request #2958 · phpredis/phpredis Conversation
Contributor
A master with no replicas is a valid Redis Cluster topology. When a long-lived client receives MOVED to a master absent from its map, Only search for a promoted replica when a replica table exists. Otherwise, use the existing new-node redirect path. Known-replica promotion still remaps the keyspace and preserves remap errors. The per-slot path is the one develop already takes for an unknown MOVED target, so no extra keyspace remap is introduced. Remapping during a failover still uses only the configured seeds; that is unchanged and out of scope here. The regression supplies a stale slot map through a one-shot seed and exercises real MOVED replies, repeated reads, and a subsequent write against the test cluster. It does not alter cluster ownership or require stopping replicas in CI. Validation
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Only search the previous master for a promoted replica when its replica table exists. Otherwise, let the existing new-node MOVED path recover the slot mapping. Add a stale-map seed fixture and regression covering repeated reads and a subsequent write. Fixes phpredis#2740. Fixes phpredis#2828. This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. RedisClusterException: Redis Cluster's master data is incomplete. Cluster is in invalid state. cluster_update_slot failing if new master addedUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |