GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Close the socket when a reply is only partly read by SnowySailor · Pull Request #2961 · phpredis/phpredis

Conversation

@SnowySailor

@SnowySailor SnowySailor commented Oct 14, 2026

Copy link
Copy Markdown

Fixes #2960

When a read fails or times out partway through a reply, phpredis throws but leaves the socket open. The rest of the reply arrives later, and the next command reads it as its own reply, so the connection stays out of step. This PR disconnects wherever phpredis gives up before the end of a reply, the same way redis_sock_gets() already does:

  • a short read in redis_sock_read_bulk_reply() and redis_sock_read_bulk_zstr()
  • a timeout before the reply type byte in redis_read_reply_type()
  • an unknown reply type byte in redis_sock_read() and redis_sock_read_zstr()
  • any failed read in cluster_check_response(), which now also rejects unknown reply type bytes
  • a mismatched reply in cluster_send_direct(), and a mismatched reply with an unread payload in cluster_send_slot()

Testing

  • The repro from Socket stays open after a read timeout in the middle of a reply, so every later command reads an earlier command's reply #2960 (Valkey 9.0 behind Toxiproxy), for Redis and RedisCluster, with binary and CRLF-text values: after the change, the command after the timeout reconnects and gets its own reply.
  • Two more delayed-reply cases that this fixes: a node-directed RedisCluster::echo(), and Redis::rawCommand() with a timeout before the type byte.
  • The same cases with TLS, persistent connections, and the igbinary serializer.
  • tests/TestRedis.php --class Redis and --class RedisCluster (6-node cluster with the phpredis ACL user, as in CI) give the same results with and without the change. The only failures are session tests, testFailedTransactions, and testQueuedReplyModes, which fail in my local environment on develop too.

There is no new unit test, because the bug needs a server that stops partway through a reply. I can add one if you have a preferred way to do that in the test suite.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@SnowySailor
Close the socket when a reply is only partly read
79bb0ad
When a read fails or times out in the middle of a reply, the rest of
the reply can still arrive. If the socket stays open, the next command
reads it as its own reply and the connection stays out of step.

Disconnect wherever we give up before the end of a reply, the same way
redis_sock_gets() already does:

* a short read in redis_sock_read_bulk_reply() and
  redis_sock_read_bulk_zstr()
* a timeout before the reply type byte in redis_read_reply_type()
* an unknown reply type byte in redis_sock_read() and
  redis_sock_read_zstr()
* any failed read in cluster_check_response(), which now also rejects
  unknown reply type bytes
* a mismatched reply in cluster_send_direct(), and a mismatched reply
  with an unread payload in cluster_send_slot()

Fixes phpredis#2960

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Socket stays open after a read timeout in the middle of a reply, so every later command reads an earlier command's reply

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@SnowySailor
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.