GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Close the socket when a reply is only partly read by SnowySailor · Pull Request #2961 · phpredis/phpredis ConversationFixes #2960 When a read fails or times out partway through a reply, phpredis throws but leaves the socket open. The rest of the reply arrives later, and the next command reads it as its own reply, so the connection stays out of step. This PR disconnects wherever phpredis gives up before the end of a reply, the same way
Testing
There is no new unit test, because the bug needs a server that stops partway through a reply. I can add one if you have a preferred way to do that in the test suite.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsWhen a read fails or times out in the middle of a reply, the rest of the reply can still arrive. If the socket stays open, the next command reads it as its own reply and the connection stays out of step. Disconnect wherever we give up before the end of a reply, the same way redis_sock_gets() already does: * a short read in redis_sock_read_bulk_reply() and redis_sock_read_bulk_zstr() * a timeout before the reply type byte in redis_read_reply_type() * an unknown reply type byte in redis_sock_read() and redis_sock_read_zstr() * any failed read in cluster_check_response(), which now also rejects unknown reply type bytes * a mismatched reply in cluster_send_direct(), and a mismatched reply with an unread payload in cluster_send_slot() Fixes phpredis#2960 This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Socket stays open after a read timeout in the middle of a reply, so every later command reads an earlier command's replyUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |