GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Merge EmptyDataProviderRule into 2.1.x by staabm · Pull Request #352 · phpstan/phpstan-phpunit

Conversation

@staabm

@staabm staabm commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I did not realize that #328 had a target branch of 2.0.x.. merging now into 2.1.x which is the latest release branch atm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@SanderMuller @claude @staabm
Report a data provider that provides no data sets (#328)
d310360
* Report a data provider that provides no data sets

PHPUnit 10 and newer rejects a data provider that provides nothing.
PHPUnit 9 skipped the test instead.

EmptyDataProviderRule reports a provider method whose every return
statement returns an iterable that is provably empty. It skips
generators, because whether a generator yields at all depends on control
flow the rule cannot decide.

Closes #251

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>

* cheap checks first

---------

Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
Co-authored-by: Markus Staab <[email protected]>
@staabm
staabm marked this pull request as ready for review November 12, 2026 15:26
@staabm
staabm merged commit 13cc64d into 2.1.x Nov 12, 2026
203 of 206 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@staabm @SanderMuller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.