GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — New CodeQL codemod for mitigating Regex DoS by andrecsilva · Pull Request #484 · pixee/codemodder-java

Conversation

@andrecsilva

@andrecsilva andrecsilva commented Dec 10, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

\close #work

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andrecsilva
andrecsilva force-pushed the ISS-2495/codeql-regex-dos branch from 1015216 to 6599c3e Compare December 10, 2024 10:10
@andrecsilva
andrecsilva marked this pull request as ready for review December 10, 2024 10:24
@andrecsilva
andrecsilva requested a review from nahsra December 10, 2024 11:08
nahsra
nahsra requested changes Dec 10, 2024
View reviewed changes

@nahsra nahsra left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a complicated change that will be repeated many times in the codebase. Is there any chance we can get a function like this in the codebase, or add it to the java security toolkit?

If it’s something that must be delivered inline, we should have unit tests that test the code we insert to make sure it’s doing what we think it’s doing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
andrecsilva added 4 commits December 17, 2024 09:27
@andrecsilva
Initial work
1b8d8a4
@andrecsilva
Codemod plus tests
54196e0
@andrecsilva
Fixed remediation metadata
25f1f06
@andrecsilva
Modified transformation to use security package
b8b90cd
@andrecsilva
andrecsilva force-pushed the ISS-2495/codeql-regex-dos branch from 48c961a to b8b90cd Compare December 17, 2024 12:44
@sonarqubecloud

sonarqubecloud Bot commented Dec 17, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
pixeebot[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nahsra nahsra nahsra requested changes

Requested changes must be addressed to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@andrecsilva @nahsra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.