GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixed error with changing execute statements in SQLi codemods by andrecsilva · Pull Request #494 · pixee/codemodder-java

Conversation

@andrecsilva

@andrecsilva andrecsilva commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andrecsilva
Fixed error with changing execute statements in SQLi codemods
2e5a0ab
@andrecsilva
andrecsilva marked this pull request as ready for review February 7, 2025 11:24
@andrecsilva
andrecsilva requested a review from nahsra February 7, 2025 11:24
nahsra
nahsra reviewed Feb 7, 2025
View reviewed changes
Comment thread ...k/codemodder-base/src/main/java/io/codemodder/remediation/sqlinjection/SQLParameterizer.java Outdated
@@ -725,7 +724,6 @@ private MethodCallExpr fixByHijackedStatement(

// TODO will this work for every type of execute statement? or just executeQuery?

@nahsra nahsra Feb 7, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this comment need to be adjusted?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@andrecsilva andrecsilva Feb 7, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember exactly why it's there, but we can probably safely remove this one, the transformation is restricted to only 4 types of execute statements. All of these have an equivalent version in PreparedStatement objects.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andrecsilva
Removed stale TODO
941e63f
@sonarqubecloud

sonarqubecloud Bot commented Feb 7, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nahsra
nahsra approved these changes Feb 7, 2025
View reviewed changes
@andrecsilva
andrecsilva merged commit 0c387e4 into main Feb 7, 2025
@andrecsilva
andrecsilva deleted the sqli-comp-error branch February 7, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nahsra nahsra nahsra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@andrecsilva @nahsra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.