GeezerVison is showing github.com — fix: handle unresolved dev DNS updater hostnames by immanuwell · Pull Request #2375 · pixie-io/pixie
Conversation
immanuwell
commented
May 21, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary:
Tiny dev_dns_updater papercut: if a LoadBalancer reports a hostname and local DNS can't resolve it yet, the updater used to ignore the lookup error and index ip[0]. That can panic instead of waiting for the next Service update. This now logs the miss and keeps watching, no drama.
Relevant Issues:
Related #484
Related #2209
Type of change:
/kind bug
Test Plan:
Repro: send watchForExternalIP a Service event with status.loadBalancer.ingress[0].hostname set, while DNS lookup returns an error or no IPs. Before this change it hits ip[0] and panics; after this change it skips that update and keeps running.
go test ./src/utils/dev_dns_updater
bazel test //src/utils/dev_dns_updater:dev_dns_updater_test --test_output=errors
Changelog Message:
N/A
Additional documentation:
N/A
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch had an error being deployed
1 failed
deployment
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.