GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: correct date axis timezone in hoveranywhere/clickanywhere events by godfengliang · Pull Request #7818 · plotly/plotly.js

Conversation

@godfengliang

@godfengliang godfengliang commented Jun 1, 2026

Copy link
Copy Markdown

Fixes #7816.

For date axes, p2c returns a display-time value (local-time components encoded as UTC ms). This caused hoveranywhere and clickanywhere events to report timestamps shifted by the local timezone offset.

Fix: after p2c for date axes, apply timezone correction to convert back to true UTC ms.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@godfengliang
fix: correct date axis timezone in hoveranywhere/clickanywhere events
5e252a3 
Fixes plotly#7816.
@godfengliang godfengliang mentioned this pull request Jun 1, 2026
[BUG]: hoveranywhere / clickanywhere return incorrect timestamps for date axes with local time zones #7816
Closed
@camdecoster

camdecoster commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR! Our team is taking a look at this area of the code, so we'll review your PR in tandem and follow up with you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@camdecoster camdecoster assigned emilykl Aug 5, 2026
@emilykl

emilykl commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@godfengliang Thank you for this PR, as it prompted us to look more closely at this issue.

The proposed fix addresses the immediate issue, but it's not consistent with conventions that we use elsewhere in plotly.js. Milliseconds in plotly.js are always in the local time zone; timezone-agnostic times are only provided as date strings. (This is probably a bad pattern, but changing it would require a larger refactor of the library.)

I've opened #7964 with a fix that's more consistent with the way the rest of plotly.js behaves. I'll leave this PR open while discussion continues over there, but I think we'll most likely end up pursuing an approach along those lines rather than this one.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emilykl

emilykl commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Closing in favor of #7964.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emilykl emilykl closed this Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@emilykl emilykl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: hoveranywhere / clickanywhere return incorrect timestamps for date axes with local time zones

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@godfengliang @camdecoster @emilykl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.