GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Handle geojson features that cross antimeridian in computeBbox by camdecoster · Pull Request #7891 · plotly/plotly.js

Conversation

camdecoster commented Jul 6, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Description

Update computeBbox to handle geojson features that cross the antimeridian.

Closes #4436.

Changes

Use d3-geo to get coords for features that cross the antimeridian instead of turn/bbox
Update computeBbox call sites
Add/update tests

Testing

Be on master
Load Plotly devtools

Paste the following snippet into the browser devtools console

Plotly.newPlot(gd, [{
    type: 'choropleth',
    locations: ['RUS'],
    z: [1],
    colorscale: [[0, '#c33'], [1, '#c33']],
    showscale: false
}], {
    geo: { fitbounds: 'locations', projection: { type: 'equirectangular' } },
    width: 700,
    height: 500,
    margin: { l: 0, r: 0, t: 0, b: 0 }
});

Note that the plot spans the whole world
Switch to this branch
Run the snippet again
Note that the plot spans only Asia

Screenshots

Before	After

Notes

This has been a long-standing TODO (from 2019)
@turf/bbox doesn't handle geometry that spans the antimeridian and there's been no movement to fix that issue
This update uses a D3 utility (d3-geo.geoBounds, that does work with the antimeridian) to do the same thing (along with a turf utility used within @turf/bbox)
This could be considered a breaking change as some plots will show something different for the same config

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

camdecoster added 5 commits

July 6, 2026 16:28


          Linting/formatting

6b25af1


          Update computeBbox to handle antimeridian crossing polygons

b3c6fa8


          Update computeBbox calls to handle null return value

43aba1d


          Add/update tests

66604e5


          Add draftlog

57880fc

camdecoster self-assigned this

Jul 6, 2026

camdecoster added this to the v4.0.0 milestone

Jul 6, 2026

camdecoster marked this pull request as ready for review

July 6, 2026 22:51


          Merge remote-tracking branch 'origin/v4.0' into cam/4436/handle-geojs…

dd0eacd

…on-antimeridian

emilykl reviewed

Jul 7, 2026

View reviewed changes

Comment thread

src/traces/choropleth/plot.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

emilykl reviewed

Jul 7, 2026

View reviewed changes

Comment thread

src/traces/choropleth/plot.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

emilykl reviewed

Jul 7, 2026

View reviewed changes

Comment thread

src/lib/geo_location_utils.js

Comment on lines +396 to +399

		* @return {[number, number, number, number]\|null} `[west, south, east, north]`
		* in degrees; `east` may exceed 180° when the input crosses ±180°.
		* Returns `null` for input with no extractable coordinates (e.g. `Sphere`,
		* empty FeatureCollection).

emilykl Jul 7, 2026

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand this docstring to clarify the numeric range of each coordinate, and any constraints on the output, and also whether east is guaranteed to exceed 180 if the input crosses the antimeridian?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

camdecoster Jul 7, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a bit more info, but some of what you're asking for seems out of scope of a docstring.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

emilykl reviewed

Jul 7, 2026

View reviewed changes

Comment thread

src/lib/geo_location_utils.js Outdated

Comment on lines +415 to +416

		// Pass as MultiPoint to sidestep d3-geo's polygon winding assumption (CW
		// exterior, opposite of RFC 7946) and geodesic apex overshoot

emilykl Jul 7, 2026

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what CW exterior or geodesic apex overshoot mean, could you tweak this comment to be a bit more readable?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

camdecoster Jul 7, 2026

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's confusing. I'll simplify it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

emilykl reviewed

Jul 7, 2026

View reviewed changes

Comment thread

src/lib/geo_location_utils.js Outdated

		return [
		west,
		south,
		east < west ? east + ANTIMERIDIAN_LON_SHIFT : east, // Unwrap antimeridian crossing; east may exceed 180°

emilykl Jul 7, 2026

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use unwrapLonRange() here now that #7881 is merged, right?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

camdecoster Jul 7, 2026

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is slightly different, but I can probably get everything to use the same calc. I'll update it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

emilykl reviewed

Jul 7, 2026

View reviewed changes

Comment thread

src/lib/geo_location_utils.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

emilykl reviewed

Jul 7, 2026

View reviewed changes

Comment thread

src/traces/choropleth/plot.js Outdated

		@@ -54,17 +54,25 @@ function calcGeoJSON(calcTrace, fullLayout) {
		calcPt._polygons = geoUtils.feature2polygons(feature);

		var bboxFeature = geoUtils.computeBbox(feature);

emilykl Jul 7, 2026

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this issue predates your changes, but it seems a little silly to compute bounding boxes for all the features here if they might be ignored in the next step. Maybe a small refactor would make sense?

It's beyond the scope of this PR though so not necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

camdecoster Jul 7, 2026

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! That does seem a bit wasteful. Let me poke at it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

emilykl reviewed

Jul 7, 2026

View reviewed changes

Comment thread

test/jasmine/tests/geo_test.js

		}

		describe('Test geo fitbounds with antimeridian-straddling points', function() {
		describe('Test geo fitbounds with antimeridian-straddling points', function () {

emilykl Jul 7, 2026

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding a similar test here for choropleth to verify the changes end-to-end? And/or an image test? (I'm a little surprised that none of the existing image baselines changed as a result of these changes, but I guess it requires a pretty specific combination of factors to surface this issue.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

camdecoster Jul 7, 2026

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the follow up work to default to fitbounds = "locations", I'll address adding tests. This one just needed to be updated because of computeBbox changed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

emilykl approved these changes

Jul 7, 2026

View reviewed changes

emilykl left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nitpick comments, but LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

camdecoster added 4 commits

July 7, 2026 15:24


          Only compute feature bboxes if whole geojson bbox is falsy

02b14ca


          Update comments; use unwrapLonRange for check

7dbd215


          Linting/formatting

44198ae


          Add test

88d8c4e

camdecoster merged commit 8476f59 into v4.0

Jul 7, 2026

84 checks passed

Uh oh!

There was an error while loading. Please reload this page.

camdecoster deleted the cam/4436/handle-geojson-antimeridian branch

July 7, 2026 22:45

Reviewers

1 more reviewer

emilykl

emilykl approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

camdecoster

Labels

None yet

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

camdecoster commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Testing

Screenshots

Notes

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camdecoster Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emilykl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camdecoster commented Jul 6, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

camdecoster Jul 7, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.