GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update "Share chart" dialog wording by emilykl · Pull Request #7928 · plotly/plotly.js

Conversation

@emilykl

@emilykl emilykl commented Aug 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Update "Share chart" dialog with more informative wording
    • Add hyperlink to Plotly Cloud
  • Update button tooltip to add an ellipsis ("Share chart...")
  • Update and add Jasmine tests to cover dialog code

Codepen demo: https://codepen.io/emilykl-code/pen/PwWKqej

Dialog
Screenshot 2026-08-04 at 9 38 54 AM

Button tooltip

Screenshot 2026-08-04 at 9 39 14 AM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
emilykl added 2 commits August 3, 2026 11:49
@emilykl
Update wording in 'Share Chart' dialog. Provide different wording for…
3f62263 
… default (Plotly Cloud) URL vs. ccustom URL provided in config
@emilykl
update jasmine tests for share chart dialog
431d559
@emilykl
emilykl requested review from camdecoster, ndrezn and red-patience August 3, 2026 18:30
@red-patience

red-patience commented Aug 3, 2026

Copy link
Copy Markdown

LGTM!
emilykl reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ndrezn

ndrezn commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Should this be sentence case? @red-patience
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@red-patience

red-patience commented Aug 3, 2026

Copy link
Copy Markdown

Should this be sentence case? @red-patience

If this sets a new precedent then I would recommend sentence case but if not, then consistency with what exists already.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emilykl

emilykl commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Should this be sentence case? @red-patience

Which part?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ndrezn

ndrezn commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

"Share chart" instead of current "Share Chart"
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emilykl emilykl changed the title Update "Share Chart" dialog wording Update "Share chart" dialog wording Aug 4, 2026
@emilykl

emilykl commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

@red-patience @ndrezn I don't feel strongly either way, and there's not much precedent in plotly.js itself, so I've lowercased the word "chart" both in the button tooltip and the dialog title.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
camdecoster
camdecoster approved these changes Aug 4, 2026
View reviewed changes

@camdecoster camdecoster left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, but no blockers.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread draftlogs/7928_change.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/components/modebar/buttons.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/components/modebar/cloud_confirm.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/components/modebar/cloud_confirm.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
emilykl added 3 commits August 5, 2026 11:24
@emilykl
add draftlog
072fe84
@emilykl
tweak wording
3a9781d
@emilykl
lowercase the word 'chart'
4897de4
@emilykl
emilykl force-pushed the update-cloud-dialog-wording branch from 5bc58da to 4897de4 Compare August 5, 2026 15:29
emilykl and others added 3 commits August 5, 2026 11:29
@emilykl @camdecoster
Update src/components/modebar/cloud_confirm.js
a569bdd 
Co-authored-by: Cameron DeCoster <[email protected]>
@emilykl
small refactor; create strings file
573747b
@emilykl
update invalid protocal error message
f3b78fb
@emilykl
emilykl merged commit aa8c68c into v4.0 Aug 5, 2026
85 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@emilykl
emilykl deleted the update-cloud-dialog-wording branch August 5, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camdecoster camdecoster camdecoster approved these changes
@ndrezn ndrezn Awaiting requested review from ndrezn
@red-patience red-patience Awaiting requested review from red-patience

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@emilykl @red-patience @ndrezn @camdecoster
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.