GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Format date tick labels with minor-tick precision when using `ticklabelindex` by my-tien · Pull Request #7935 · plotly/plotly.js

Conversation

@my-tien

@my-tien my-tien commented Aug 5, 2026 •
edited by camdecoster
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix #7933 by determining the tick format using the rounded ticks of the minor axis instead of the major axis when ticklabelindex is set.

Stacks on top of #7934.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@my-tien
my-tien force-pushed the 7933-minor-ticklabel-format branch from b701674 to 77d7d26 Compare August 5, 2026 14:50
@robertclaus
robertclaus requested a review from camdecoster August 6, 2026 19:33
@robertclaus robertclaus assigned camdecoster Aug 6, 2026
@camdecoster camdecoster changed the title 7933 minor ticklabel format fix: Format date tick labels with minor-tick precision when using ticklabelindex Sep 24, 2026
camdecoster
camdecoster reviewed Sep 24, 2026
View reviewed changes
Comment thread draftlogs/7935_fix.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/plots/cartesian/axes.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/plots/cartesian/axes.js Outdated
// axis is just necessary when using ticklabelindex.
autoTickRound(mockAx);
delete mockAx.minor; // prevent self-reference
Lib.extendFlat(ax.minor, mockAx);

@camdecoster camdecoster Sep 24, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you trying to copy over on this line? I think it might be better to save the specific keys you're looking for than adding the entirety of mockAx.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@my-tien my-tien Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now only copy the _tickround value over that is used in formatDate.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@camdecoster camdecoster mentioned this pull request Sep 24, 2026
fix: Fix missing last period label with negative ticklabelindex #7937
Open
@my-tien my-tien mentioned this pull request Oct 2, 2026
fix: Center period labels over their own period when using ticklabelindex #7934
Merged
my-tien added 7 commits October 9, 2026 15:44
@my-tien
When using ticklabelindex, make sure tick labels use formatting compa…
b4f3b85 
…tible with minor ticks.

E.g. if major ticks are daily and minor ticks are hourly, tick labels on minor ticks should include hourly information.
@my-tien
Adjust date_axes_period2_ticklabelindex baseline image after fixing p…
e9e7f55 
…eriod labels

The longer period labels need more space.
@my-tien
Draftlog for PR 7935
3bcc0ad
@my-tien
Update baseline image for date_axes_period2_ticklabelindex
bbf2681
@my-tien
Fix PR number in draft log 7935
4bbba5e
@my-tien
prepMinorTicks: copy only mockAx._tickround instead of all props
858e520
@my-tien
Remove accidental overwrite of fmt in formatDate
60241b8
@my-tien
my-tien force-pushed the 7933-minor-ticklabel-format branch from 140c33b to 60241b8 Compare October 9, 2026 15:07
@my-tien
Update date_axes_period2_ticklabelindex.png
9da5633 
The positioning of the tick label was fixed in b4d49bd and this PR was rebased on top.
@my-tien
my-tien requested a review from camdecoster October 9, 2026 15:21
@camdecoster
Update draftlog
5d6636b
camdecoster
camdecoster approved these changes Oct 13, 2026
View reviewed changes
@camdecoster
camdecoster merged commit afeb782 into plotly:main Oct 13, 2026
86 of 87 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camdecoster camdecoster camdecoster approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@camdecoster camdecoster

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: tickformat doesn't adjust when labels are positioned below minor ticks (because of ticklabelindex)

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@my-tien @camdecoster
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.