GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||
GeezerVison is showing github.com — fix: Improve handling of auto-fitting with many features and the antimeridian on geo traces by camdecoster · Pull Request #7948 · plotly/plotly.js Conversation
|
| Before | After |
|---|---|
![]() |
![]() |
Plotly.newPlot(gd, [{ type: 'choropleth', locations: ['CAN', 'USA', 'MEX'], locationmode: 'ISO-3', z: [3, 2, 1], showscale: false }], { geo: { projection: { type: 'equirectangular' } }, width: 700, height: 450 });
getAutoRange
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| * @param {object} trace - a `fullData` trace | ||
| * @param {object} geoLayout - the subplot's `fullLayout` entry | ||
| * @return {Array|null} `[west, south, east, north]`, or null whenever | ||
| * `fitGeojsonCoords` is empty — in which case the caller falls back to the data. |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I don't like this pattern of describing what the calling function will do. The docstring should document this function's behavior, not the behavior of the calling function.
| * `fitGeojsonCoords` is empty — in which case the caller falls back to the data. | |
| * `fitGeojsonCoords` is empty. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
From a data-visualization perspective, probably better to turn off auto-fitting for this mock.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Nice
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.