GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix issue where plot fails to render if unsupported MathJax version is present on page by emilykl · Pull Request #7951 · plotly/plotly.js

Conversation

@emilykl

@emilykl emilykl commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Link to Issue

Closes #7926

Description

Fixes an issue where the presence of an unsupported MathJax version on the page would cause the entire plot not to render if it contained a tex string ($...$).

This was due to the code path which detected an unsupported MathJax version not calling _callback() directly the way we did in other failure cases. This PR adds a call to _callback() in that case, and adds regression tests for the issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
emilykl added 3 commits August 9, 2026 12:26
@emilykl
ensure that plot still renders in the case where an unsupported MathJ…
716bac1
…ax version is present
@emilykl
add regression tests
dae92a8
@emilykl
add draftlog
64eeb40
@emilykl
emilykl changed the base branch from master to v4.0 August 9, 2026 16:31
@emilykl
emilykl requested a review from camdecoster August 9, 2026 16:31
@emilykl emilykl added this to the v4.0.0 milestone Aug 9, 2026
@emilykl emilykl changed the title Fix issue where plot failed to render if unsupported MathJax version was present on page Fix issue where plot failed to render if unsupported MathJax version is present on page Aug 10, 2026
@camdecoster camdecoster changed the title Fix issue where plot failed to render if unsupported MathJax version is present on page Fix issue where plot fails to render if unsupported MathJax version is present on page Aug 10, 2026
camdecoster
camdecoster approved these changes Aug 10, 2026
View reviewed changes

@camdecoster camdecoster left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left one suggestion.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread draftlogs/7951_fix.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/lib/svg_text_utils.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

emilykl and others added 2 commits August 13, 2026 14:45
@emilykl
clean up MathJax version check
7f82b30
@emilykl @camdecoster
Update draftlogs/7951_fix.md
6aaf901
Co-authored-by: Cameron DeCoster <[email protected]>
@emilykl
emilykl merged commit fcf6e99 into v4.0 Aug 13, 2026
244 of 247 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@emilykl
emilykl deleted the fix-mathjax-issue branch August 13, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camdecoster camdecoster camdecoster approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

[BUG]: 4.0 RC: Unsupported MathJax version causes entire plot not to render

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@emilykl @camdecoster
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.