GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — feat: add legend.groupdoubleclick to set group behavior on double-click by tisankanj · Pull Request #7997 · plotly/plotly.js Conversation
Contributor
Summary
Closes #6812 Why this shape
The isolation path now honors the resolved group value. This corrects one existing case. With
TestsSuite: Result on my machine, Chrome 151: New specs:
I put the old isolation line back and ran the suite again. That run reported No new mock, and no baseline moves. The attribute changes no drawn output before a user double-clicks. Rendered checkI loaded the local bundle and compared two figures that hold the same four traces. Trace 1 and trace 3 share
The two figures render the same before the double click. A second double click restores Checks
Note
🐦
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionshandleItemClick read groupclick for every action, so a double click could not differ from a single click. A figure could not keep togglegroup on a single click and isolate one trace on a double click. groupdoubleclick takes the coerced groupclick value as its default, so a figure that omits the attribute keeps the current behavior. The isolation path now honors the resolved group value, which corrects the case where groupclick is toggleitem and the double click still isolated a whole legendgroup. Closes plotly#6812
emilykl
reviewed
Uh oh!
There was an error while loading. Please reload this page.
emilykl
reviewed
Uh oh!
There was an error while loading. Please reload this page.
emilykl
reviewed
Uh oh!
There was an error while loading. Please reload this page. Co-authored-by: Emily KL <[email protected]>
emilykl
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the contribution @rascal-sl, this looks good! 🎉 For the record, while testing this PR, we did notice that it's not necessarily always obvious what the behavior of various However that's probably a topic to be addressed in a different PR. The implementation of
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers1 more reviewerUh oh!
There was an error while loading. Please reload this page. AssigneesLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. add'toggleitem' for layout.legend.groupdoubleclick
Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |