GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Include type defs in appropriate partial bundles by camdecoster · Pull Request #8001 · plotly/plotly.js

Conversation

@camdecoster

@camdecoster camdecoster commented Aug 31, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Description

Include the type definitions in the plotly.js-dist, plotly.js-dist-min partial bundles.

Closes #7996.

Changes

  • Add types during packaging
  • Linting/formatting

Testing

  • Be on this branch
  • Run DRYRUN=1 node tasks/sync_packages.js
  • Note that the type files are include in the correct packages

Notes

  • Ideally, a user would be able to use this package in a browser, but that's not possible right now due to Node specific dependencies
  • I'm going to open another issue to track that An issue already exists: Webpack v5 compatibility issue (with workaround) #6014
  • This PR should land after fix: Compile TS to JS during packaging #8000

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
camdecoster added 4 commits August 31, 2026 15:48
@camdecoster
Linting/formatting
4f5b7c5
@camdecoster
fix: Include type defs in appropriate partial bundles
f1a4a98
@camdecoster
Also run npm publish (as dry run) in DRYRUN block
d584c25
@camdecoster
Add draftlog
1fc4c97
@camdecoster
camdecoster marked this pull request as ready for review August 31, 2026 22:19
emilykl
emilykl previously approved these changes Sep 1, 2026
View reviewed changes

@emilykl emilykl left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a clear comment towards the top of sync_packages.js stating exactly which bundles have the types files included?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@camdecoster
Update comment
9678204
@camdecoster
camdecoster dismissed emilykl’s stale review via 9678204 September 1, 2026 13:45
@camdecoster

camdecoster commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Looking at it again, this doesn't need to wait for #8000 to merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
emilykl
emilykl approved these changes Sep 1, 2026
View reviewed changes
@camdecoster
camdecoster merged commit 56a3e18 into main Sep 1, 2026
82 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@camdecoster
camdecoster deleted the cam/7996/include-types-partial-bundles branch September 1, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@emilykl emilykl emilykl approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Allow using v4 bundled types for the browser

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@camdecoster @emilykl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.