GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Include trace-contributed layout attributes in generated types by camdecoster · Pull Request #8020 · plotly/plotly.js

Conversation

@camdecoster

@camdecoster camdecoster commented Sep 4, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Description

Update type generator to include trace-contributed layout attributes.

Closes #8018.

Changes

  • Update generator script
  • Update types
  • Update docs

Testing

  • Be on main
  • Save the following in the project root:
    import type { Layout, PolarLayout } from './src/types/index';
    declare const l: Layout;
    declare const p: PolarLayout;
    l.barmode = 'relative'; l.barnorm = 'fraction'; l.bargap = 0.1;
    l.boxmode = 'group'; l.violinmode = 'overlay'; l.funnelmode = 'stack';
    l.waterfallmode = 'group'; l.scattermode = 'group'; l.hiddenlabels = ['a'];
    l.piecolorway = ['red']; l.sunburstcolorway = ['red']; l.treemapcolorway = ['red'];
    l.iciclecolorway = ['red']; l.funnelareacolorway = ['red']; l.extendpiecolors = true;
    p.barmode = 'overlay'; p.bargap = 0.3;
    l.polar2 = { barmode: 'stack' };
    // @ts-expect-error barpolar supports only stack/overlay
    p.barmode = 'relative';
    // @ts-expect-error enum still rejects bad values
    l.barmode = 'nonsense';
    // @ts-expect-error unknown keys still rejected
    l.notAReal = 1;
  • Run the following command:
    npx tsc --noEmit --ignoreConfig --strict --skipLibCheck --moduleResolution bundler --module esnext --target es2020 ./temp.ts
    
  • Note that the result is an error
  • Switch to this branch
  • Run the command again
  • Note that no error occurs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
camdecoster added 3 commits September 4, 2026 13:34
@camdecoster
fix: Include trace-contributed layout attributes in generated types
614db7f
@camdecoster
Update TS docs
d44bd44
@camdecoster
Add draftlog
afb03c9
@camdecoster
camdecoster marked this pull request as ready for review September 4, 2026 20:01
@camdecoster
Fix draftlog name
038ce20
@KoolADE85 KoolADE85 self-assigned this Sep 4, 2026
KoolADE85
KoolADE85 approved these changes Sep 4, 2026
View reviewed changes

@KoolADE85 KoolADE85 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 💃

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@camdecoster
camdecoster merged commit fe6422f into main Sep 4, 2026
86 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@camdecoster
camdecoster deleted the cam/8018/include-trace-layout-attributes branch September 4, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KoolADE85 KoolADE85 KoolADE85 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@KoolADE85 KoolADE85

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: Layout type is missing all trace-contributed layout attributes in v4.0.0 (barmode, boxmode, scattermode, …)

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@camdecoster @KoolADE85
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.