GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(quiver): honor discrete marker.color arrays by Yahiro025 · Pull Request #8069 · plotly/plotly.js

Conversation

@Yahiro025

@Yahiro025 Yahiro025 commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #8026.

A discrete marker.color array on a quiver trace left every arrow black. Array colors made the stroke argument undefined, and an unset stroke draws black. Numeric arrays still go through the colorscale later; a list of color strings does not turn the colorscale on, so every arrow stayed rgb(0, 0, 0).

strokeArrowColors in src/traces/quiver/style.js still sends numeric arrays through the colorscale. For any other array it sets each valid color string on that arrow. src/traces/quiver/plot.js uses the same helper so the first draw and a later restyle stay in sync.

Draftlog

Placeholder draftlogs/XXXX_fix.md will be renamed to match this PR number after open.

Test plan

  • Jasmine quiver suite: new discrete marker.color regression + existing coverage (18/18)
  • lint, typecheck, test-syntax

Notes

Assisted by AI tooling; reviewed before opening. Authorship Yahiro025-only.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Yahiro025 added 4 commits September 23, 2026 02:58
@Yahiro025
Fix discrete quiver marker colors
e218052 
A marker.color array of color strings skipped the colorscale path. lineGroupStyle then left the stroke unset, so every arrow drew black.

Co-authored-by: Bennett Payoyo <[email protected]>
@Yahiro025
Add the quiver color draftlog
9f694b2 
The entry uses a placeholder number until the upstream pull request exists. Rename draftlogs/XXXX_fix.md to that pull request number.

Co-authored-by: Bennett Payoyo <[email protected]>
@Yahiro025
chore: rename quiver draftlog to PR 8069
37eb275
@Yahiro025
chore: remove placeholder quiver draftlog
4ed74e5
@camdecoster camdecoster self-assigned this Sep 23, 2026
Yahiro025 and others added 3 commits September 30, 2026 12:29
@Yahiro025
Merge upstream main
4d1516e 
Bring the branch up to date with the default branch.
The rangeslider drag failure is outside the quiver diff.
@camdecoster
Minor formatting updates
3aefeff
@camdecoster
Update draftlog
622f234
camdecoster
camdecoster approved these changes Oct 19, 2026
View reviewed changes

@camdecoster camdecoster left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@camdecoster
camdecoster merged commit 93b8c97 into plotly:main Oct 19, 2026
86 of 87 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camdecoster camdecoster camdecoster approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@camdecoster camdecoster

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: The quiver trace ignores a discrete marker.color array and results in every arrow being black

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Yahiro025 @camdecoster
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.