GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix numeric and numeric-string marker symbol variant detection in `scattergl` by Lexachoc · Pull Request #8071 · plotly/plotly.js

Conversation

@Lexachoc

@Lexachoc Lexachoc commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Closes #8070

Fix marker variant detection in scattergl for numeric (100, 200, and 300) and numeric-string ('100', '200' and '300') symbol values.

This PR makes numeric (numeric-string) symbol representations behave consistently with their named equivalents for scattergl and all WebGL-based traces that reuse its marker handling.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Lexachoc added 2 commits September 24, 2026 01:48
@Lexachoc
fix numeric marker variant detection issue in scattergl
38dc465
@Lexachoc
add draftlog
3e604cf
@Lexachoc Lexachoc changed the title Fix numeric marker variant detection issue in scattergl Fix numeric and numeric-string marker symbol variant detection in scattergl Sep 23, 2026
@Lexachoc
edit draftlog
691dad1
@Lexachoc
Lexachoc marked this pull request as draft September 24, 2026 09:40
@Lexachoc
Lexachoc marked this pull request as ready for review September 24, 2026 09:40
@Lexachoc

Lexachoc commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

I think there was an issue with GitHub yesterday that caused many of the checks to fail. However, I can't seem to find an option to re-run the failed checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
camdecoster
camdecoster requested changes Sep 25, 2026
View reviewed changes

@camdecoster camdecoster left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Your update solves the problem. When I was reviewing, I found a helper function that could simplify this a bit. Let me know what you think.

Could you please add a unit test that covers these functions?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/traces/scattergl/helpers.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/traces/scattergl/helpers.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/traces/scattergl/helpers.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@camdecoster camdecoster self-assigned this Sep 25, 2026
@Lexachoc
Apply suggestions from code review and add unit test
9c3d038
@Lexachoc

Lexachoc commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

I applied your suggestion and added unit tests for the marker symbol detection.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Lexachoc
Lexachoc requested a review from camdecoster October 6, 2026 15:22
@Lexachoc
Merge branch 'main' into fix-scattergl-marker-symbol-display
88cbefd
camdecoster
camdecoster approved these changes Oct 22, 2026
View reviewed changes
@camdecoster
camdecoster merged commit 96c9eb3 into plotly:main Oct 22, 2026
87 of 88 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camdecoster camdecoster camdecoster approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@camdecoster camdecoster

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: scattergl incorrectly handles numeric and numeric-string marker variants

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Lexachoc @camdecoster
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.