GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix funnel percentTotal text formatting by ORITOMI · Pull Request #8139 · plotly/plotly.js

Conversation

@ORITOMI

@ORITOMI ORITOMI commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #8137.

This PR fixes a typo in src/traces/bar/plot.js that caused funnel text templates using %{percentTotal} to display raw ratios instead of formatted percentages.

Changes

  • Corrected percenTotalLabel to percentTotalLabel.
  • Added a regression test in test/jasmine/tests/funnel_test.js to verify that %{percentTotal} renders as 50%, 33%, and 17%.

Screenshots

Before :

percentTotal_before

After :

percentTotal_after

Testing

  • Funnel Jasmine tests pass (63 tests).
  • Lint checks pass.
  • Type checking passes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ORITOMI added 2 commits October 21, 2026 09:06
@ORITOMI
Fix funnel percentTotal text formatting
f9c4de1
@ORITOMI
Add draftlog for funnel percentage fix
6910b11
@camdecoster camdecoster self-assigned this Oct 21, 2026
@camdecoster
Update draftlog
6458372
camdecoster
camdecoster approved these changes Oct 21, 2026
View reviewed changes

@camdecoster camdecoster left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! This was a sneaky bug.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ORITOMI reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@camdecoster
camdecoster merged commit c7aefae into plotly:main Oct 21, 2026
76 of 88 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@ORITOMI ORITOMI mentioned this pull request Oct 21, 2026
percentTotal not shown as percentage plotly/plotly.py#4368
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camdecoster camdecoster camdecoster approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@camdecoster camdecoster

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: percentTotal not shown as percentage

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ORITOMI @camdecoster
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.