GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix tick prefixes and suffixes with explicit tick values by davrens101 · Pull Request #8160 · plotly/plotly.js

Conversation

@davrens101

@davrens101 davrens101 commented Nov 1, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix tick prefixes and suffixes with explicit tick values

Fixes #8006.

arrayTicks passes String(undefined) as the noSuffixPrefix flag when a tick has no explicit text. That nonempty string suppresses the prefix and suffix. Pass a boolean that tests whether explicit text exists instead. Custom ticktext retains its existing behavior.

Regression coverage

The axes Jasmine suite covers linear, log, date, and category axes. The regression also covers partial custom text and the all, first, last, and none display modes.

Prior local runs used Chrome Headless 156 on Windows:

Source, with the new regression Passed Failed Total
Pristine upstream source 398 5 403
Patched source 399 4 403

The new regression fails before the fix and passes after the fix. Four pre-existing failures remain in each run:

  • should make room for the inside labels of the counter axes
  • can relayout insiderange
  • should rotate labels to avoid overlaps
  • insiderange react to new data

The numerical errors match across those runs. The suite is not fully green.

The local evidence runner excludes unrelated MapLibre CSS. The installed esbuild-plugin-inline-css throws at path.resolve(undefined, args.path). No upstream configuration or dependency changes form part of this patch.

These results come from the preparation logs, not a new submission-time run. Lint, typecheck, syntax, schema-drift, and full CI results are not available. No schema, public API, dependency, mock, or generated type changes occur. No local image baselines were generated. Maintainer CI must confirm the standard checks and any affected baselines.

Rendered evidence

The source-built reproduction uses tickvals: [0, 1, 2], tickprefix: '$', and ticksuffix: ' USD':

Before: 0, 1, 2
After:  $0 USD, $1 USD, $2 USD

The submission agent inspected the saved before/after screenshots. Screenshots and complete logs remain in the local evidence package. This CLI submission does not attach images or claim public screenshot URLs. The issue contains the original visual report.

Review and disclosure

AI assisted the patch, regression test, review, and submission. The user approved submission: "go ahead and submit it looks good to me". That approval is not a claim of independent maintainer review. 🐦

Commit c8ecfd27a4e52229b17d598ad18243189a2f221e replaces the placeholder with draftlogs/8160_fix.md and the actual PR link.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
davrens101 added 2 commits October 31, 2026 23:48
@davrens101
Fix tick prefixes and suffixes for explicit tick values
e953f2a
@davrens101
Link the tick prefix and suffix draftlog to PR 8160
c8ecfd2
@KoolADE85 KoolADE85 self-assigned this Nov 2, 2026
@KoolADE85
KoolADE85 self-requested a review November 2, 2026 21:08
@KoolADE85
Merge branch 'main' into fix/tickvals-prefix-suffix
b58ee69
KoolADE85
KoolADE85 reviewed Nov 6, 2026
View reviewed changes
Comment thread draftlogs/8160_fix.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@KoolADE85
Apply suggestion from @KoolADE85
636ea7d
KoolADE85
KoolADE85 approved these changes Nov 6, 2026
View reviewed changes

@KoolADE85 KoolADE85 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @davrens101 ! It's working well on my end.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@KoolADE85
KoolADE85 merged commit 7d92747 into plotly:main Nov 6, 2026
1 check passed

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KoolADE85 KoolADE85 KoolADE85 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@KoolADE85 KoolADE85

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] [REGRESSION]: tickprefix/ticksuffix ignored when tickvals provided

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@davrens101 @KoolADE85
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.