GeezerVison is showing github.com — Update bundled versioneer for Python 3.11 compatibility by hugovk · Pull Request #3545 · plotly/plotly.py
Conversation
hugovk
commented
Jan 12, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Please uncomment this block and take a look at this checklist if your PR is making substantial changes to documentation/impacts files in the doc directory. Check all that apply to your PR, and leave the rest unchecked to discuss with your reviewer! Not all boxes must be checked for every PR :)
If your PR modifies code of the plotly package, we have a different checklist
below :-).
Documentation PR
- I've seen the
doc/README.md file
- This change runs in the current version of Plotly on PyPI and targets the
doc-prod branch OR it targets the master branch
- If this PR modifies the first example in a page or adds a new one, it is a
px example if at all possible
- Every new/modified example has a descriptive title and motivating sentence or paragraph
- Every new/modified example is independently runnable
- Every new/modified example is optimized for short line count and focuses on the Plotly/visualization-related aspects of the example rather than the computation required to produce the data being visualized
- Meaningful/relatable datasets are used for all new examples instead of randomly-generated data where possible
- The random seed is set if using randomly-generated data in new/modified examples
- New/modified remote datasets are loaded from https://plotly.github.io/datasets and added to https://github.com/plotly/datasets
- Large computations are avoided in the new/modified examples in favour of loading remote datasets that represent the output of such computations
- Imports are
plotly.graph_objects as go / plotly.express as px / plotly.io as pio
- Data frames are always called
df
-
fig = <something> call is high up in each new/modified example (either px.<something> or make_subplots or go.Figure)
- Liberal use is made of
fig.add_* and fig.update_* rather than go.Figure(data=..., layout=...) in every new/modified example
- Specific adders and updaters like
fig.add_shape and fig.update_xaxes are used instead of big fig.update_layout calls in every new/modified example
-
fig.show() is at the end of each new/modified example
-
plotly.plot() and plotly.iplot() are not used in any new/modified example
- Hex codes for colors are not used in any new/modified example in favour of these nice ones
Code PR
- I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of
plotly.graph_objects, my modifications concern the codegen files and not generated files.
- I have added tests (if submitting a new feature or correcting a bug) or
modified existing tests.
- For a new feature, I have added documentation examples in an existing or
new tutorial notebook (please see the doc checklist as well).
- I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
- For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).
Versioneer 0.18 uses SafeConfigParser which has been removed from Python 3.11 (set for release in October).
https://docs.python.org/3.11/whatsnew/3.11.html
The latest Versioneer has replaced SafeConfigParser, so updating.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks for looking after this :)
|
hugovk reacted with rocket emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.