GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Fix spurious engine deprecation warning in write_image by mosh3eb · Pull Request #5517 · plotly/plotly.py Conversation
Contributor
write_image() defaulted engine='auto' and passed it to to_image(), which treats any non-None engine value as explicitly user-specified and emits a deprecation warning. By defaulting to None (matching to_image's expected interface), the warning only appears when the user actually passes an engine argument. Fixes #5512
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionswrite_image() defaulted engine='auto' and passed it to to_image(), which treats any non-None engine value as explicitly user-specified and emits a deprecation warning. By defaulting to None (matching to_image's expected interface), the warning only appears when the user actually passes an engine argument. Fixes plotly#5512
emilykl
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks @mosh3eb for the fix. This seems reasonable to me since Out of curiosity, would you be willing to share a minimal code sample and/or information on your use case where you see this warning? I believe we missed this on our end because of the fact that Thanks for catching this!
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers1 more reviewerUh oh!
There was an error while loading. Please reload this page. AssigneesLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. [BUG]: Unexpected warning when using write_imageUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |