GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix accidental creation of `js/` directory under `site-packages/` when installing Plotly by emilykl · Pull Request #5587 · plotly/plotly.py

Conversation

@emilykl

@emilykl emilykl commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Link to issue

Closes #5584

Description of change

Fixes issue since Plotly 6.7.0, introduced by #5540, where pip install plotly would unintentionally create a js/ directory under site-packages/, interfering with any other package which might use the js/ name.

Demo

N/A

Testing strategy

To reproduce the issue:

  1. Create a fresh Python virtual environment
  2. Run pip install plotly==6.7.0 (or uv pip install ...)
  3. Notice that the following directory exists: $VENV_ROOT/lib/pythonX.Y/site-packages/js

To verify that this PR fixes the issue:

  1. Check out this branch
  2. Run python -m build from the root folder, and make sure it runs without error
  • Verify that new dist/plotly-6.7.0.tar.gz and dist/plotly-6.7.0-py3-none-any.whl files are created
  1. Create a fresh Python virtual environment
  2. Run pip install dist/plotly-6.7.0-py3-none-any.whl
  3. Verify that $VENV_ROOT/lib/pythonX.Y/site-packages/js DOES NOT exist
  4. Verify that $VENV_ROOT/share/jupyter/labextensions/jupyterlab-plotly/install.json DOES exist
  5. To test installing the tar file, repeat steps 4-7 replacing the .whl file path with the .tar.gz file path

Guidelines

  • I have reviewed the pull request guidelines and the Code of Conduct and confirm that this PR follows them.
  • I have added an entry to the changelog if needed (not required for documentation PRs).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@emilykl
prevent creation of js package on install
8c7129f
@emilykl emilykl mentioned this pull request Apr 30, 2026
Fix accidental creation of js/ directory under site-packages/ when installing Plotly #5586
Closed
2 tasks done
@emilykl
emilykl requested a review from camdecoster April 30, 2026 21:38
camdecoster
camdecoster approved these changes May 1, 2026
View reviewed changes
@emilykl
emilykl merged commit 4d590f3 into main May 1, 2026
25 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@emilykl
emilykl deleted the fix-5584-2 branch May 1, 2026 14:27
@mgorny

mgorny commented May 1, 2026

Copy link
Copy Markdown
Contributor

Thank you!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camdecoster camdecoster camdecoster approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: plotly is installing js top-level package with data files

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@emilykl @mgorny @camdecoster
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.