GeezerVison is showing github.com — Update plotly.js to `v4.0.0-rc.0` by emilykl · Pull Request #5673 · plotly/plotly.py
Conversation
emilykl
commented
Jul 22, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Description of change
- Update plotly.js to
v4.0.0-rc.0
- Run codegen and regenerate Jupyter js bundles
- Remove all references to
mapbox in Plotly Express
- Update tests to remove
mapbox references
Note: The failing plotly.js dev build CI job can be ignored. That job runs the tests after pulling dist/plotly.js from the plotly.js master branch, so naturally it will fail since the plotly.js v4.0 changes are not yet on master.
The failing docs build can also be ignored; it will fail until the docs are updated to remove mapbox code, which will be in a separate PR.
Notes
Closes #4824 due to the color library update in plotly.js v4.0.0.
Closes #5081 by removing all Mapbox references.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Could we update the docs separately to keep things tidy?
- I think we can remove the Stream deprecation warning in _deprecations.py
- I still see a lot of references to
linkText/link_text and showLink/show_link. Could those be removed?
ColorValidator will need to be updated per the v4 changes
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ColorValidator will need to be updated to remove the references and regex checks for hsv since that got removed. The regex patterns will also need to be updated to match the new color specifier support.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
emilykl reacted with thumbs up emoji
- Could we update the docs separately to keep things tidy?
Yes, as long as you're OK with the docs build failing on this PR. I'll split the docs changes into a separate PR.
- I think we can remove the Stream deprecation warning in _deprecations.py
- I still see a lot of references to
linkText/link_text and showLink/show_link. Could those be removed?
ColorValidator will need to be updated per the v4 changes
👍 will do, thanks
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
|
@@ -28,26 +28,58 @@ def validator_aok_colorscale(): |
|
|
)
|
|
|
|
|
|
|
|
|
VALID_COLORS = [
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camdecoster I tried to be pretty comprehensive here, but please suggest any formats I've missed. Likewise for the invalid colors list.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 27, 2026
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|