Description

isidentical

opened on May 31, 2020

Issue body actions

Related issue: bpo-40465.

black..................................................................../home/isidentical/.venv/lib/python3.10/site-packages/pre_commit/languages/helpers.py:95: DeprecationWarning: The *random* parameter to shuffle() has been deprecated
since Python 3.9 and will be removed in a subsequent version.
  random.shuffle(seq, random=fixed_random.random)
Passed

Activity

1. asottile commented on May 31, 2020

   

   asottile

   on May 31, 2020

   Member

   More actions

   well that's annoying.
2. asottile

   added

   upstream-bug

   on May 31, 2020
3. serhiy-storchaka commented on May 31, 2020

   

   serhiy-storchaka

   on May 31, 2020

   More actions

   Why not to use just

   fixed_random.shuffle(seq)

   ?
4. asottile commented on May 31, 2020

   

   asottile

   on May 31, 2020

   Member

   More actions

   is that documented? I don't see it on https://docs.python.org/3/library/random.html
5. serhiy-storchaka commented on May 31, 2020

   

   serhiy-storchaka

   on May 31, 2020

   More actions

   https://docs.python.org/3.9/library/random.html#random.shuffle
6. asottile commented on May 31, 2020

   

   asottile

   on May 31, 2020

   Member

   More actions

   yeah that's what the current code is using?
7. isidentical commented on May 31, 2020

   

   isidentical

   on May 31, 2020

   Author

   More actions

   yeah that's what the current code is using?

   I think what @serhiy-storchaka is suggesting that, since you set a custom seed you can use directly fixed_random's shuffle method.

   def _shuffled(seq: Sequence[str]) -> List[str]:
       """Deterministically shuffle"""
       fixed_random = random.Random()
       fixed_random.seed(FIXED_RANDOM_SEED, version=1)
   
       seq = list(seq)
       fixed_random.shuffle(seq)
       return seq
8. asottile commented on May 31, 2020

   

   asottile

   on May 31, 2020

   Member

   More actions

   I get that, but where in the documentation does it say that Random has a shuffle method -- the link above is to the module's function
9. serhiy-storchaka commented on May 31, 2020

   

   serhiy-storchaka

   on May 31, 2020

   More actions

   The functions supplied by this module are actually bound methods of a hidden instance of the random.Random class. You can instantiate your own instances of Random to get generators that don’t share state.
10. asottile commented on May 31, 2020

    

    asottile

    on May 31, 2020

    Member

    More actions

    🤦 and here I was expecting it to be documented under https://docs.python.org/3/library/random.html#random.Random
11. asottile

    closed this as completedin #1480on May 31, 2020

Issue actions