GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — make `stages` and `hook-type` match · Issue #2732 · pre-commit/pre-commit

make stages and hook-type match #2732

New issue
Copy link
New issue
Copy link
Open
Open
make stages and hook-type match#2732
Copy link
Labels
cleanupfeaturegood-first-issue

Description

@asottile
asottile
opened on Jan 30, 2023
Issue body actions

this is mostly a confusion point / slightly annoying and a mistake I made when first introducing new hook types

currently all of the --hook-type and stages values match except for these three:

  • pre-commit: commit
  • pre-merge-commit: merge-commit
  • pre-push: push

I'd like to deprecate the mismatched names!

this is going to need a long deprecation period since it's sorta subtle and usually not the user's fault and will need hook authors to (potentially) make updates

the plan is to do the following:

  1. introduce the following in a minor release
    • no deprecation notice in this initial release (give authors / users some time to update without warnings)
    • the new names are available in addition to the old names
    • migrate-config will autofix .pre-commit-config.yaml usages of stages with the old values (there isn't an equivalent migrate-manifest -- though users outnumber hook authors by several orders of magnitude)
  2. introduce the following in a minor release
    • a warning is shown for configuration using the old stages names
    • a warning is shown for repos using the old stages names (do this at install time so it only shows once as to not be super annoying for users who have no control)
    • a recommendation for hook authors to also set minimum_pre_commit_version to this version
  3. a long time passes (typically my deprecation period has been 12-18+ months)
  4. introduce the following in a major release
    • removal of the old names
Reacted by Kyle Balston, swaldhoer, James Lamb, Will Hawthorn, Ben Falk and Freso
Reacted by Marsha, Kyle King, Yan Ang, Adam Johnson, Matt Clarkson, Helio Machado, Tom Vendolsky, Joshua Sleeper and Nate Douglas

Activity

  1. asottile
    added
    feature
    cleanup
    good-first-issue
    on Jan 30, 2023
  2. jaypikay
    added a commit that references this issue on Apr 27, 2023

    chore(deps): update dependency pre-commit to v3 (#2)

    ddc28c5
  3. espressif-bot
    added a commit that references this issue on Dec 29, 2023

    fix: allow to use older pre-commit hook version

    09ba070
  4. bbannier
    added 2 commits that reference this issue on Oct 6, 2024

    Stop using deprecated pre-commit stage names.

    45d9282

    Stop using deprecated pre-commit stage names.

    b81a8f3
  5. ysndr
    added a commit that references this issue on Nov 29, 2024

    ci: update `git-hooks.nix` flake and migrate `push` hook to `pre-push`

    231c0e2
  6. github-merge-queue
    added a commit that references this issue on Dec 4, 2024

    ci: update `git-hooks.nix` flake and migrate `push` hook to `pre-push`

    1adaebc
  7. CheckmkCI
    added a commit that references this issue on May 30, 2025

    pre-commit: Fix deprecated stage names

    b92a9d4
  8. timsu92
    added 2 commits that reference this issue on Aug 6, 2025

    fix(init): use pre-push as pre-commit stage

    68e8fd4

    fix(init): use pre-push as pre-commit stage

    b43a614
  9. Lee-W
    added 2 commits that reference this issue on Aug 7, 2025

    fix(init): use pre-push as pre-commit stage

    a2fe54b

    fix(init): use pre-push as pre-commit stage

    9cfb55e
  10. archana-1209 commented on Aug 11, 2025

    @archana-1209
    archana-1209
    on Aug 11, 2025
    More actions

    is someone working on this , or can I pick this up ? @asottile

  11. asottile commented on Aug 11, 2025

    @asottile
    asottile
    on Aug 11, 2025
    MemberAuthor
    More actions

    @archana-1209 we're sort of in the "wait out the deprecation period" phase of this so at the time there isn't much to do

  12. Lee-W
    added a commit that references this issue on Aug 17, 2025

    fix(init): use pre-push as pre-commit stage

    d9058b6
  13. Lee-W
    added 3 commits that reference this issue on Aug 28, 2025

    fix(init): use pre-push as pre-commit stage

    719b35c

    fix(init): use pre-push as pre-commit stage

    7b619f8

    fix(init): use pre-push as pre-commit stage

    f69972e
  14. Lee-W
    added 4 commits that reference this issue on Sep 9, 2025

    fix(init): use pre-push as pre-commit stage

    1d7c53b

    fix(init): use pre-push as pre-commit stage

    187eb07

    fix(init): use pre-push as pre-commit stage

    4cbf485

    fix(init): use pre-push as pre-commit stage

    1fb11e0
  15. vemilano
    added 2 commits that reference this issue on Dec 10, 2025

    fix(init): use pre-push as pre-commit stage

    bf5f321

    fix(init): use pre-push as pre-commit stage

    cb02c15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cleanupfeaturegood-first-issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.