Description

ojob

opened on Aug 19, 2025

Issue body actions

search you tried in the issue tracker

ignore-prepublish, npm

describe your actual problem

With #3516, I reported that pipelines we run in Gitlab-CI fail on an warning+error raised by npm at installation of markdownlint-cli by pre-commit.

Reading the execution log from related issue, it appears that:

• npm raises a warning about the deprecated option --ignore-prepublish.

Analysis

The --ignore-prepublish option has been introduced by pre-commit 5 years ago.

However:

• prepublish is marked as deprecated in NPM8 (but one can consider this has been the case for almost a decade).
• currently, running installation of, say, markdownlint-cli raises the following warning in Gitlab-CI: Unknown cli config "--ignore-prepublish". This will stop working in the next major version of npm.

What is requested

In pre_commit/languages/node.py, the --ignore-prepublish option shall be either removed, or activable on a per-project basis if backward compatibility is somehow necessary (I know nothing about Node applications).

Some additional thoughts, here since I could find no other relevant place

I understand that non-actionable issues shall be closed. But closing #3516 without any way to improve/clarify the request or even only to comment is rude, considering preparation of such an issue takes time and tries to bring value to this project. Please consider allowing some delay before disallowing comments.

pre-commit --version

4.2.0

Reacted by Paweł Cisło, hlovdal, Raphael Rösch, Patrick Marx, Johannes Wienke and Birger Johan Nordølum

Activity

1. asottile commented on Aug 19, 2025

   

   asottile

   on Aug 19, 2025

   Member

   More actions

   I understand that non-actionable issues shall be closed. But closing #3516 without any way to improve/clarify the request or even only to comment is rude, considering preparation of such an issue takes time and tries to bring value to this project. Please consider allowing some delay before disallowing comments.

   I mean your output literally said "report this to npm" and you decided to open the issue here? your issue was off topic to begin with, unhelpful (and far from "bringing value to the project"), and did not deserve further discussion.

   yes I locked it there was nothing more to discuss if you think that's rude you may want to adjust your expectations of what you're entitled to in open source
2. ojob commented on Aug 19, 2025

   

   ojob

   on Aug 19, 2025

   Author

   More actions

   The comment at the bottom is not about the technical content of the first issue I opened today. It only proposes a way to handle exchange between humans, in a way that seems acceptable to me, hoping this would be a shared point of view.

   This issue is about updating pre-commit call to npm install, by removing a deprecated option.
3. asottile commented on Aug 19, 2025

   

   asottile

   on Aug 19, 2025

   Member

   More actions

   This issue is about updating pre-commit call to npm install, by removing a deprecated option.

   then don't clutter this issue with your unnecessary commentary

   Reacted by Ülgen Sarıkavak, Dhaval Gojiya, Josh J, Ziyu Wang, hlovdal, YuXuan Tay and Raven
4. ojob commented on Aug 20, 2025

   

   ojob

   on Aug 20, 2025

   Author

   More actions

   After npm logs retrieval, it appears that the npm error is not raised due to the highlighted warning, which was not obvious from the recorder stderr. So I updated the issue description to be more specific.
5. pyxelr commented on Oct 24, 2025

   

   pyxelr

   on Oct 24, 2025 · Hidden as off-topic

   show commentMore actions
6. asottile commented on Oct 24, 2025

   

   asottile

   on Oct 24, 2025

   Member

   More actions

   you're seeing a warning like the original post. but that is just a warning. warnings are not fatal.
7. pyxelr

   added a commit that references this issue on Oct 27, 2025

   ➕ Add ;pre-commitrunskipmarkdownlint

   70b89ff
8. languitar commented on Jul 13, 2026

   

   languitar

   on Jul 13, 2026

   More actions

   This is now an actual error:

   pre_commit.util.CalledProcessError: command: ('.../bin/node', '/usr/sbin/npm', 'install', '--include=dev', '--include=prod', '--ignore-prepublish', '--no-progress', '--no-save')
   return code: 1
   stdout: (none)
   stderr:
       npm error code EUNKNOWNCONFIG
       npm error Unknown cli flag:
       npm error   - --ignore-prepublish
       npm error Run `npm help config` for supported options.
   

   Reacted by Travis Illig, Jannis Mainczyk, Chris Herborth, Shane Frasier and ripssi
9. asottile

   closed this as completedin #3719on Jul 15, 2026
10. rlichtenwalter

    added 4 commits that reference this issue on Oct 16, 2026

    chore: Update pre-commit hooks

    177e0e7

    chore: Update pre-commit hooks

    7502f47

    chore: Update pre-commit hooks

    9b3e95a

    chore: Update pre-commit hooks

    134b5b8

Issue actions