GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add ban for pgp/gpg private key blocks to detect_private_key by rpdelaney · Pull Request #329 · pre-commit/pre-commit-hooks

Conversation

@rpdelaney

@rpdelaney rpdelaney commented Oct 22, 2018

Copy link
Copy Markdown
Contributor

Adds ''BEGIN PGP PRIVATE KEY BLOCK" to the banlist for detect_private_key.py.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rpdelaney
Add ban for pgp/gpg private key blocks
b1feed0
asottile
asottile approved these changes Oct 22, 2018
View reviewed changes
@asottile

asottile commented Oct 22, 2018

Copy link
Copy Markdown
Member

github is a mess, let me verify the tests locally
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asottile

asottile commented Oct 22, 2018

Copy link
Copy Markdown
Member 
  py27: commands succeeded
  py36: commands succeeded
  congratulations :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asottile
asottile merged commit 86bfe8c into pre-commit:master Oct 22, 2018
@asottile

asottile commented Oct 22, 2018

Copy link
Copy Markdown
Member

🎉 thanks for the PR!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rpdelaney rpdelaney mentioned this pull request Nov 21, 2018
Ban unarmored GPG keys #339
Open
@joshuarli joshuarli mentioned this pull request Dec 18, 2018
blacklist pgp private key header Yelp/detect-secrets#104
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rpdelaney @asottile
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.