GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix comments with indents by greshilov · Pull Request #549 · pre-commit/pre-commit-hooks

Conversation

@greshilov

@greshilov greshilov commented Jan 17, 2021

Copy link
Copy Markdown
Contributor

Fix for #548.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
asottile
asottile reviewed Jan 17, 2021
View reviewed changes
Comment thread requirements-dev.txt Outdated
covdefaults
coverage
pytest
ruamel.yaml

@asottile asottile Jan 17, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not correct

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@greshilov greshilov Jan 17, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted.

I was unable to run tests without this package.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@asottile asottile Jan 17, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably have extremely old setuptools / pip / tox / virtualenv-- upgrade those

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
greshilov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@greshilov greshilov Jan 17, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, looks like I misconfigured something.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@greshilov
greshilov force-pushed the fix-comments-with-indents branch from 54a8c0a to 093109e Compare January 17, 2021 19:14
@greshilov
requirements-txt-fixer now supports indents before comments
28b2c8e
@greshilov
greshilov force-pushed the fix-comments-with-indents branch from 093109e to 28b2c8e Compare January 17, 2021 19:15
asottile
asottile approved these changes Jan 17, 2021
View reviewed changes

@asottile asottile left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
greshilov reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@asottile
asottile merged commit 43f5ffa into pre-commit:master Jan 17, 2021
MasterSlave420
MasterSlave420 reviewed Feb 2, 2021
View reviewed changes

@MasterSlave420 MasterSlave420 left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghost

ghost commented May 14, 2021

Copy link
Copy Markdown

Thanks for adding this.

@asottile do you know when the next release would be approximately?
There's a few additions I'd like to use, this included 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asottile

asottile commented May 14, 2021

Copy link
Copy Markdown
Member

Thanks for adding this.

@asottile do you know when the next release would be approximately?
There's a few additions I'd like to use, this included 😄

the next release will be when the next release is

please don't ask for releases (from anyone, not just me), it's borderline rude -- if you want free work consider sponsoring
skrawani reacted with thumbs down emoji
All reactions
  • 👎 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost

ghost commented May 14, 2021

Copy link
Copy Markdown

@asottile ,
Sorry, about that.
I’ve better informed myself and I now see that was very bad etiquette on my behalf. Thank you for correcting it :)


I appreciate you and your work.





Please accept my apology. :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes
+1 more reviewer
@MasterSlave420 MasterSlave420 MasterSlave420 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@greshilov @asottile @MasterSlave420
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.