GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix too long floating point number parse problem by SilverTux · Pull Request #818 · pre-commit/pre-commit-hooks

Conversation

@SilverTux

@SilverTux SilverTux commented Oct 6, 2022

Copy link
Copy Markdown
  • Also include @dougthor42's diff to test the fix
    see: his diff
  • Soution for pretty-format-json modifies floating point numbers that have too many digits of precision #780

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
SilverTux and others added 2 commits October 6, 2022 18:19
@SilverTux
Fix too long floating point number parse problem
629df55 
  - Also include @dougthor42's diff to test the fix
    see: [his diff](pre-commit/pre-commit-hooks@main...dougthor42:high-precision-numbers)
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2e029b7 
for more information, see https://pre-commit.ci
asottile
asottile reviewed Oct 6, 2022
View reviewed changes
Comment thread pre_commit_hooks/pretty_format_json.py
from typing import Mapping
from typing import Sequence

import simplejson as json

@asottile asottile Oct 6, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, don't want to pull in any more dependencies

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@asottile asottile closed this Oct 6, 2022
@SilverTux SilverTux mentioned this pull request Oct 6, 2022
pretty-format-json modifies floating point numbers that have too many digits of precision #780
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@SilverTux @asottile
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.