GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Docs: add note about pre-push hooks not being triggered on ref deletions by whophil · Pull Request #893 · pre-commit/pre-commit.com

Conversation

@whophil

@whophil whophil commented Nov 3, 2023

Copy link
Copy Markdown

Documents behavior described in pre-commit/pre-commit#3050

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@whophil
Add note about pre-push hooks not being triggered on ref deletions
2b85105
asottile
asottile reviewed Nov 3, 2023
View reviewed changes
Comment thread sections/advanced.md
Comment on lines +185 to +186
note: `pre-push` hooks are not triggered for ref deletions.

@asottile asottile Nov 3, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a bit more nuance to this than just that -- the variables below imply this is already the case since there must be a from-ref and a to-ref

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@whophil whophil Nov 3, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the environment variables, I was expecting PRE_COMMIT_TO_REF to be 0000000000000000000000000000000000000000 here, in the case of a ref deletion.

Would you propose an alternate wording, or not documenting this at all?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@whophil @asottile
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.