GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add `use client` directives to the created mjs wrappers by Andarist · Pull Request #590 · preconstruct/preconstruct

Conversation

@Andarist

@Andarist Andarist commented Mar 26, 2024

Copy link
Copy Markdown
Member

fixes bvaughn/react-error-boundary#182

I'm not 100% sure if this should be done at all though. It doesn't solve the case when the directive is in non-entrypoint file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Andarist
Add use client directives to the created mjs wrappers
985e57f
@Andarist
Andarist requested a review from emmatown March 26, 2024 07:51
@changeset-bot

changeset-bot Bot commented Mar 26, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 985e57f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Andarist
Andarist commented Mar 26, 2024
View reviewed changes
Comment thread packages/cli/src/build/__tests__/other.ts
exports.a = a;

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ dist/pkg.cjs.mjs ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
'use client';

@Andarist Andarist Mar 26, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now the use client directive is in this file and the one that it reexports (the CJS file) - I think it should be harmless, right?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@codecov

codecov Bot commented Mar 26, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.39%. Comparing base (9f44a11) to head (985e57f).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #590   +/-   ##
=======================================
  Coverage   92.38%   92.39%           
=======================================
  Files          39       39           
  Lines        2049     2051    +2     
  Branches      625      639   +14     
=======================================
+ Hits         1893     1895    +2     
  Misses        146      146           
  Partials       10       10

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Andarist Andarist mentioned this pull request Mar 26, 2024
"use client" not appearing in the ESM entry bvaughn/react-error-boundary#182
Closed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmatown emmatown Awaiting requested review from emmatown

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"use client" not appearing in the ESM entry

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Andarist
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.