GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — Set release tag from time and date by SableRaf · Pull Request #431 · processing/processing-website ConversationSet tag from time and date
SableRaf
marked this pull request as ready for review
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
Right now I'm automatically creating the unique tag, not the version name. I'm actually not sure where the idea of having a unique tag for each release started or if it is necessary but I emulated it here. Automatically generating the version name would be tricky, since we may want to get the website out of Beta at some point, or bump it up from version 7 to 8 at some point and this is subjective and not a decision we can easily automate. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for that. The unique tag is only needed for the GitHub release, since GitHub uses this to make a Git tag in the current HEAD of the branch. I was just wondering whether we need the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Changed version to title and tweaked input descriptions
@runemadsen: Gotcha! I made this change. Do these commit look ok? I'm kinda new to the whole GH workflows thing :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Looks good to me! I've never set an ENV variable like this, but give it a whirl and see how it goes! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Hmm, yeah that doesn't seem to be the proper way to set env variables. I'll fix this before merging. Edit: the normal way to set environment variables doesn't work for dynamic variables. this is promising: https://github.com/orgs/community/discussions/26342 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
properly set the GitHub environment variable (untested)
|
@runemadsen It worked! Here's what I ended up with: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Great! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.