GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Low contrast between background and foreground colors (text) by shahnoor-khan · Pull Request #441 · processing/processing-website

Conversation

@shahnoor-khan

@shahnoor-khan shahnoor-khan commented Feb 13, 2023

Copy link
Copy Markdown

worked on issue #427 .
changed the color contrast between background and hover color in footer, so the people with color blindness can also read clearly.
Before the hover color of anchor tag used to be like this:
image
to this:
Screenshot_20230213_062854

Changes made on footer:
Screenshot_20230212_084104
to this:
Screenshot_20230212_083818
I'm new to open source contributions. Can I work further on this issue #427 to improve the website?
Any advice will be appreciated :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
shahnoor-khan added 2 commits February 12, 2023 20:33
@shahnoor-khan
changed the color contrast between background and hover color in footer.
ca78a58
@shahnoor-khan
Low contrast between background and foreground colors (text)
f64c9e8
@SableRaf
SableRaf requested a review from runemadsen February 13, 2023 13:21
@SableRaf

SableRaf commented Feb 13, 2023

Copy link
Copy Markdown
Collaborator

Thanks for your contribution @shahnoor-khan! ⭐️ Tagging @runemadsen for review
shahnoor-khan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shahnoor-khan
Merge branch 'processing:main' into main
4b10a7e
@SableRaf SableRaf mentioned this pull request Feb 24, 2023
Low contrast between background and foreground colors (text) #427
Open
@SableRaf

SableRaf commented May 30, 2023

Copy link
Copy Markdown
Collaborator

Hi @shahnoor-khan,

Thanks for your work on issue #427. A couple of things before we can merge the PR:

  1. Could we change the yellow in the footer to a light blue that's already used in the site's design?
  2. While the on-click text color for cards is improved, the default grey could still use more contrast against the white.

Thanks for your help on this!

Raphaël
shahnoor-khan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shahnoor-khan

shahnoor-khan commented Jun 2, 2023

Copy link
Copy Markdown
Author

Hey @SableRaf
Thanks for reviewing changes.

  1. Yes, we could do that and I actually tried yellow because light and dark were getting mixed with each other but I could change that again.
  2. Ok, I'll go with darker gray there.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shahnoor-khan
Merge branch 'processing:main' into main
8799861
Stefterv
Stefterv approved these changes Jul 26, 2024
View reviewed changes
@SableRaf

SableRaf commented Jul 30, 2024

Copy link
Copy Markdown
Collaborator

@Stefterv Thanks for reviewing this but I think you may have missed the changes I requested in my May 30, 2023 reply :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Stefterv Stefterv Stefterv approved these changes
@runemadsen runemadsen Awaiting requested review from runemadsen

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@shahnoor-khan @SableRaf @Stefterv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.