GeezerVison is showing github.com — Adding unit tests for PShapeOBJ in processing:core by jaredacord · Pull Request #1081 · processing/processing4
Conversation
jaredacord
commented
May 7, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
This is my first PR here, so please let me know if my understanding is incorrect anywhere!
This PR is to add unit tests, focused mostly on parsing, for PShapeOBJ. These test cases hit about 50% line coverage on the PShapeOBJ class.
Closes #1077
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Stefterv reacted with eyes emoji
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More than one year later...Great work! Thank you so much
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
catilac
catilac approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.