GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Internal Gradle Runner by Stefterv · Pull Request #1234 · processing/processing4 Conversation
|
|
@catilac Does it make sense to revisit this or should I close it? |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
|
@Stefterv I think so. I feel like it would be helpful to get community support behind it. People wanting to use it, and I could definitely use help reviewing this. I can help advocate for this change, too. It could be helpful to update this PR with info on how it works so I and others can review effectively if you're able. |
All reactions
-
👍 1 reaction
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Stefterv
commented
Feb 10, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Member
Author
|
Okay I've gotten it up to date with Also added more some info in the PR |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…cessing4 into gradle-runner-final
catilac
removed their request for review
March 1, 2026 18:37
kjhollen
self-requested a review
May 12, 2026 15:02
kjhollen
marked this pull request as ready for review
May 12, 2026 15:03
kjhollen
reviewed
May 12, 2026
kjhollen
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Stef, thanks for getting this enormous project started. It will be a huge help to match up the internal build system for sketches with the new gradle system for the wider PDE.
I haven't been able to review all of this in detail, but have run and tested this and left some comments based on the user experience. The main points are:
- there's some new technical jargon in the UI that I'd like to see us wrap with friendlier text, in the current build status
- the new Settings tab feels like a duplication of functionality we already have, so I'd be in favor of merging that with existing settings and moving the run on Android feature to a menu item from the main menu (Android mode currently puts this in the Sketch menu, I think)
- the app name says ProcessingKt now in the mac menu bar (though I'm not sure if this is because of how I ran the app)
I'm also not able to run any P3D examples when I use ./gradlew run. Here's an example of the error output I get:
In Processing code:
processing.opengl.PSurfaceJOGL.initDisplay() @ processing/opengl/PSurfaceJOGL.java:144
processing.opengl.PSurfaceJOGL.initFrame() @ processing/opengl/PSurfaceJOGL.java:131
processing.core.PApplet.initSurface() @ processing/core/PApplet.java:10236
processing.core.PApplet.runSketch() @ processing/core/PApplet.java:10142
processing.core.PApplet.main() @ processing/core/PApplet.java:9861
In your code:
jogamp.newt.DisplayImpl.create() @ jogamp/newt/DisplayImpl.java:314
com.jogamp.newt.NewtFactory.createDisplay() @ com/jogamp/newt/NewtFactory.java:170
com.jogamp.newt.NewtFactory.createDisplay() @ com/jogamp/newt/NewtFactory.java:152
sketch.main() @ sketch.java:56
Exception: java.lang.RuntimeException @ jogamp/newt/DisplayImpl.java:314
java.lang.RuntimeException: com.jogamp.nativewindow.NativeWindowException: Failed to find or initialize class <.macosx.DisplayDriver> -> <jogamp.newt.driver.macosx.DisplayDriver>: windowRepaint
at jogamp.newt.DisplayImpl.create(DisplayImpl.java:314)
at com.jogamp.newt.NewtFactory.createDisplay(NewtFactory.java:170)
at com.jogamp.newt.NewtFactory.createDisplay(NewtFactory.java:152)
at processing.opengl.PSurfaceJOGL.initDisplay(PSurfaceJOGL.java:144)
at processing.opengl.PSurfaceJOGL.initFrame(PSurfaceJOGL.java:131)
at processing.core.PApplet.initSurface(PApplet.java:10236)
at processing.core.PApplet.runSketch(PApplet.java:10142)
at processing.core.PApplet.main(PApplet.java:9861)
at sketch.main(sketch.java:56)
Caused by: com.jogamp.nativewindow.NativeWindowException: Failed to find or initialize class <.macosx.DisplayDriver> -> <jogamp.newt.driver.macosx.DisplayDriver>: windowRepaint
at com.jogamp.newt.NewtFactory.getCustomClass(NewtFactory.java:114)
at jogamp.newt.DisplayImpl.getDisplayClass(DisplayImpl.java:279)
at jogamp.newt.DisplayImpl.create(DisplayImpl.java:285)
... 8 more
Caused by: java.lang.NoSuchMethodError: windowRepaint
at jogamp.newt.driver.macosx.WindowDriver.initIDs0(Native Method)
at jogamp.newt.driver.macosx.DisplayDriver.<clinit>(DisplayDriver.java:67)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:375)
at com.jogamp.newt.NewtFactory.getCustomClass(NewtFactory.java:112)
... 10 more
Could not execute build using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.11-bin.zip'.
Execution failed for task ':run'.
Execution failed for task ':run'.
Process 'command '/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home/bin/java'' finished with non-zero exit value 1
I think our next step is to more clearly define scope for an initial implementation and write an issue that we can use to direct further work. Generally, I'd like to see us match (and modernize) current functionality in an initial patch, then add in new features separately later.
Thank you so much for all your work on this. Let me know if you want to continue with updates or if you'd prefer for someone else to pick up the work from here.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
| preferences.editor.smooth=Enable antialiasing in the code editor | ||
| preferences.editor.caret.blink=Blink the caret | ||
| preferences.editor.caret.block=Use block caret | ||
| preferences.use_modern_build_system = Use modern build system (see Processing GitHub Wiki more details) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call this new or beta build system? And would it be possible to link directly to the relevant page in the wiki from here?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
|
|
||
| // TODO: Support modes other than Java | ||
| val mode = ModeContribution.load( | ||
| null, Platform.getContentFile("modes/java"), |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this code need to change to run other modes in the future? Build systems are not really my area of expertise, so I'm asking this question to understand the code better.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most files in this project end on a newline, do we want to follow that convention here?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
| } | ||
|
|
||
| // TODO: Map to .pde file again, @see JavaBuild.placeException | ||
| // TODO: This functionality should be provided by the mode |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to implement this conversion to .pde line numbers before this is merged? Presently, the console spits out the raw compilation info if the user presses the Run button, references "sketch.java" with a line number that doesn't match up to what the user sees in the PDE.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
| private fun BuildLauncher.addStateListener(){ | ||
| addProgressListener(ProgressListener { event -> | ||
| if(event is TaskStartEvent) { | ||
| editor?.statusMessage("Running task: ${event.descriptor.name}", EditorStatus.NOTICE) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI string needs internationalization
Also wondering if we should directly convey each step to the user or simplify? Right now, it feels like there's a lot of technical jargon displayed in the status message which is not ideal for beginners. I think the experimental p5.js mode handles this ok, we could borrow what they have for UI copy though I'm not sure that would be needed technically to implement this.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
| } | ||
| if(event is TaskFinishEvent) { | ||
| if(event.result is TaskSuccessResult){ | ||
| editor?.statusMessage("Finished task ${event.descriptor.name}", EditorStatus.NOTICE) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on Mac, this message only shows when the user exits the sketch window with the red button. It does not show when the user hits the stop button, the message stays stuck at "Running task. :run"
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
| val group = System.getProperty("processing.group", "org.processing") | ||
| val plugins = mutableStateListOf( | ||
| GradlePlugin( | ||
| "Hot Reload", |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this different from Tweak Mode?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
| import processing.app.ui.Theme | ||
| import kotlin.io.path.createTempDirectory | ||
|
|
||
| // TODO: Highlight errors in the editor in the right place |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a stale todo? if not, sounds like implementing this is essential before merge.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this data is shown in a new Settings tab in the editor. This gives us two places that are "Settings", one via the main title bar menu and one in a tab below the code. This may make writing documentation and directing people to Settings more confusing. Can these options go in the existing Settings window? Or can we implement building to Android device as a menu item under Sketch (as Android mode does now)?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If hot loading is a new feature, could we separate that into a future patch? Or is it intended to be a replacement for Tweak Mode?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assignedLabels
None yet
Projects
Milestone
No milestoneDevelopment
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.