GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — General cleanup of `Base` by Stefterv · Pull Request #1299 · processing/processing4

Conversation

@Stefterv

@Stefterv Stefterv commented Oct 22, 2025

Copy link
Copy Markdown
Member

I started cleaning up some of Base's startup sequence for clarity of what is being started when. Nowhere near completion and I think a lot of this class will need to be refactored in the future.

Also removed some of the timing measurement comments

Added some comments to the Processing CLI class

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Stefterv
General cleanup of Base
82a4429 
I started cleaning up some of `Base`'s startup sequence for clarity of what is being started when. Nowhere near completion and I think a lot of this class will need to be refactored in the future.

Also removed some of the timing measurement comments

Added some comments to the Processing CLI class
Stefterv
Stefterv commented Oct 22, 2025
View reviewed changes
Comment thread app/src/processing/app/Base.java

// // Check if there were previously opened sketches to be restored
// boolean opened = restoreSketches();
ContributionListing cl = ContributionListing.getInstance();

@Stefterv Stefterv Oct 22, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one thing that moved in the sequence, I think this should be okay

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@catilac catilac Oct 24, 2025

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is contribution listing?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Stefterv Stefterv Oct 27, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the helper class that will gather the contributions in the contributions manager from the net

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Stefterv
Stefterv commented Oct 22, 2025
View reviewed changes
Comment thread app/src/processing/app/Base.java
private static void setLookAndFeel() {
try {
// Use native popups to avoid looking crappy on macOS
JPopupMenu.setDefaultLightWeightPopupEnabled(false);

@Stefterv Stefterv Oct 22, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also moved in the sequence

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Stefterv
Stefterv requested a review from catilac October 22, 2025 06:30
catilac
catilac approved these changes Oct 28, 2025
View reviewed changes

@catilac catilac left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! merge when ready

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Stefterv
Stefterv merged commit 2955cb2 into processing:main Oct 28, 2025
@Stefterv
Stefterv deleted the base-vacuum branch October 28, 2025 07:34
@Stefterv Stefterv mentioned this pull request Jan 15, 2026
Added rebuildToolList() to fix nullpointer in contributions check #1381
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@catilac catilac catilac approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Stefterv @catilac
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.