GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Read preferences txt, if fails, read defaults, else really break by catilac · Pull Request #1393 · processing/processing4

Conversation

@catilac

@catilac catilac commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

This is a bandaid fix for the tab-spacing Advanced error that was reported.
I'm carving out a set of issues for a larger fix.

@SableRaf can you please give this a little test?

partial fix of #1388

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SableRaf reacted with eyes emoji
All reactions
  • 👀 1 reaction
@catilac
Read preferences txt, if fails, read defaults, else really break
0c950cd
@catilac
catilac requested a review from SableRaf January 29, 2026 01:11
@SableRaf

SableRaf commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

In a quick test it seems to work 👍 Thanks @catilac

Here's what I did:

Replicating

  1. Opened Processing 4.5.1
  2. Opened the preferences
  3. Searched for "tabs"
  4. Set editor.tabs.size to 4/ (causes error in the console)
  5. Closed and re-opened. Got the error from Preferences not validating inputs #1388

Testing the PR

  1. Built from PR branch (runs successfullly)
  2. Opened the preferences
  3. Searched for "tabs"
  4. Set editor.tabs.size to 4 (removed the trailing /)
  5. Closed Processing
  6. Re-opened 4.5.1. (starts successfully)
catilac reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SableRaf
SableRaf approved these changes Jan 29, 2026
View reviewed changes
@SableRaf

SableRaf commented Jan 29, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

@catilac What's your take on adding comments in the code to explain why a workaround like this one was needed?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@catilac

catilac commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator Author

@SableRaf i think generally that's a great idea! For this particular patch it's more like coding with a so-called best practice so it's not something too out of the ordinary. Thanks so much for reviewing will merge!
SableRaf reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@catilac
catilac merged commit 56deae8 into main Jan 29, 2026
11 of 12 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@catilac
catilac deleted the parse_int_exception branch January 29, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SableRaf SableRaf SableRaf approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@catilac @SableRaf
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.