GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add PR artifact uploads and comments by Stefterv · Pull Request #1401 · processing/processing4

Conversation

@Stefterv

@Stefterv Stefterv commented Feb 2, 2026 •
edited by SableRaf
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Update the build workflow to handle pull request runs: make the main artifact upload conditional (skip for pull_request), add a separate upload step for PR artifacts with longer retention, and post a sticky PR comment containing a download link. Also adjust workflow permissions to allow pull-request write access and include updated artifact paths.

See bot output here Stefterv#11 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Stefterv
Add PR artifact uploads and comments
918805d 
Update the build workflow to handle pull request runs: make the main artifact upload conditional (skip for pull_request), add a separate upload step for PR artifacts with longer retention, and post a sticky PR comment containing a download link. Also adjust workflow permissions to allow pull-request write access and include updated artifact paths.
@Stefterv

Stefterv commented Feb 2, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@SableRaf https://github.com/marocchino/sticky-pull-request-comment?tab=readme-ov-file#error-resource-not-accessible-by-integration it does need some configuration on Processings side.

A cool alternative could also be to use the processing-bot rather than the GitHub bot
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Stefterv added 3 commits February 2, 2026 17:45
@Stefterv
Update build workflow: PR comments and artifacts
f763f88 
Add PR-facing comments and artifact wiring to the CI workflow. Post a sticky comment after Gradle tests to indicate artifacts availability, add an upload-artifact step with an id, and update the sticky-comment step to use the artifact output URL (steps.upload-artifact.outputs.artifact-url) and a consistent header. These changes make build artifacts discoverable on pull requests.
@Stefterv
Switch to a table
8257ae6
@Stefterv
update messaging
7d24e8b
@Stefterv
Stefterv force-pushed the pr-fix branch from 64830d0 to 7d24e8b Compare February 4, 2026 12:33
@Stefterv
Use processing-bot
fd16e2f
@Stefterv
Stefterv force-pushed the pr-fix branch from f95183e to fd16e2f Compare February 4, 2026 12:45
This was referenced Feb 5, 2026
Permissions Fix #1400
Merged
use github.sha instead of ref_name #1409
Closed
catilac
catilac approved these changes Feb 5, 2026
View reviewed changes

@catilac catilac left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh okay! thank you for fixing this. in general if something is ready for review, please do tag me! i'll go ahead and merge this in

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Stefterv reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@catilac

catilac commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator

ahh okay! thank you for fixing this. in general if something is ready for review, please do tag me! i'll go ahead and merge this in

@Stefterv though i see there is a failing check. lmk when ready to merge!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Stefterv

Stefterv commented Feb 5, 2026

Copy link
Copy Markdown
Member Author

Ah true, someone in the Processing Org still needs to approve the personal access token from processing-bot
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@catilac

catilac commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator

@Stefterv ah thank you for pointing that out! just approved
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Stefterv

Stefterv commented Feb 5, 2026

Copy link
Copy Markdown
Member Author

Aaand the secret is not available as long as it is a PR... 🫠
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@catilac

catilac commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator

@Stefterv oooo should we just merge this then?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Stefterv

Stefterv commented Feb 5, 2026

Copy link
Copy Markdown
Member Author

I think so, it works on my fork and we can always disable it again later
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@catilac
catilac merged commit 75926c8 into processing:main Feb 5, 2026
8 of 10 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@catilac

catilac commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator

Merged! 🤞🏽 :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@catilac catilac mentioned this pull request Feb 5, 2026
Publish org.processing.core.dxf to Maven Central (Publish libraries to maven central) #1403
Merged
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@catilac catilac catilac approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Stefterv @catilac
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.