GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Publish Serial and IO libraries to Maven Central by avinxshKD · Pull Request #1421 · processing/processing4 Conversation
|
|
@Stefterv hey good evening, I’ve opened the PR as discussed. Please let me know if any changes are needed Thanks |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| dependencies { | ||
| compileOnly(project(":core")) | ||
| // TODO: https://github.com/java-native/jssc | ||
| implementation(files("library/jssc.jar")) |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
#1106 please see here why this was this way
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Stefterv hey... saw that TODO was left there in #1106. At the time there wasn't a good public version. Looks like If there's something from the old fork that still needs to be there pls let me knw |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Oh great, can you separate that out into a 2nd PR? I will need to look a bit deeper into that and don't want to block this one. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Stefterv sure you re right, gimme a moment |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Stefterv Done, PR now only has the IO library migration. will open a separate PR for the jssc migration later as you asked. Pls let me know |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ah, please keep the work you did on publishing the serial library, just keep the jssc jar like it was 😅 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Stefterv oh alright, give me some time college chaos ongoing 🥀 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Stefterv @catilac hey let me know if any adjustments needed. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@avinxshKD lgtm! if @Stefterv is happy with it, let's get this merged in |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Just tested on the raspi, seems fine!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Hey @Stefterv Just wanted to say I’ve genuinely enjoyed working on these migrations with you. Digging into the build setup and packaging details was a great learning experience for mee indeed :) and really appreciate the thoughtful reviews and the context you shared in b/w, it helped a lot. Also, is there a preferred place to keep an eye on upcoming or priority work for the project? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thanks @avinxshKD! There is a public Processing Roadmap. I am not entirely sure how up to date it is right now. There are also priority labels on issues, thought they might also need to be revisited based on the current state of the project. You can always ask for clarification on a given issue. The best way to see what is being worked on at the moment is probably to join discord.processing.org and chat with the maintainers on the dev channel, or attend one of the live calls with @catilac on Tuesdays! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@avinxshKD discord is best! let me know if you need help getting on discord |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @SableRaf for the pointers. I’ll go through the roadmap and keep an eye on the priority labels. Yes sure, happy to connect and discuss things with the maintainers. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
That means a lot @catilac I’ll join Discord, haven’t used it much, but will try to figure it out fs Once again thankyou all of you 🌸 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Stefterv can confirm the build works fine on a Pi 5. Y'all need any other testing before merging? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
hey @nickmcintyre thankyou so much for testing this |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@all-contributors please add @nickmcintyre for testing |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I've put up a pull request to add @nickmcintyre! 🎉 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.