GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Resource Leaks in processing/app/Util.java by SalmaneKhalili · Pull Request #1436 · processing/processing4

Conversation

@SalmaneKhalili

@SalmaneKhalili SalmaneKhalili commented Feb 15, 2026

Copy link
Copy Markdown
Contributor

This PR add a simple implementation of what was suggested in #1432, at the moment it was only applied to unzip, i should be able to do the same for the rest of the methods mentioned in the issue, but id like to have feedback on the current way im going about it.

  • Added the test to gradle path
  • added the actual test.
  • added the solution

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
SalmaneKhalili added 3 commits February 15, 2026 22:27
@SalmaneKhalili
Add java tests to build path
dac0b65 
to put the test in the appropriate directory, id have to java files to
grade build configs, because it currently only checks for kotlin tests.
@SalmaneKhalili
Unit test for rsrc leakage in unzip
1b08eec 
create a temp zip file > create a destination that is a file not a
directory (guaranteed exception) -> unzip throws ioexception because it
expects a directory not a file -> catch it -> check if the zip file is
still open -> if true == leak.
@SalmaneKhalili
Add try() to manage opened files/rsrcs
5a79e32
tychedelia
tychedelia reviewed Feb 16, 2026
View reviewed changes

@tychedelia tychedelia left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We should just either gate or remove the test.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread app/test/processing/app/UtilTest.java Outdated

@tychedelia tychedelia Feb 16, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better to not have a test than a platform specific test.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
catilac reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@SalmaneKhalili SalmaneKhalili Feb 17, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SalmaneKhalili
Applying try() to more rsrcs
27bcf6a 
Ive also removed the test since its OS specific, and new code is
supposed to be in kotlin.
@catilac

catilac commented Feb 17, 2026

Copy link
Copy Markdown
Collaborator

Thanks y'all! Running the tests. I'll go ahead an approve it
SalmaneKhalili reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
catilac
catilac approved these changes Feb 17, 2026
View reviewed changes
@catilac
catilac merged commit 05290b8 into processing:main Feb 17, 2026
6 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@catilac

catilac commented Feb 17, 2026

Copy link
Copy Markdown
Collaborator

@all-contributors please add @SalmaneKhalili for bug-finding, and bug-fixing
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@allcontributors

allcontributors Bot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

@catilac

I've put up a pull request to add @SalmaneKhalili! 🎉
SalmaneKhalili reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@allcontributors allcontributors Bot mentioned this pull request Feb 17, 2026
docs: add SalmaneKhalili as a contributor for bug #1438
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tychedelia tychedelia tychedelia left review comments
@catilac catilac catilac approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@SalmaneKhalili @catilac @tychedelia
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.