GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Resolves: #[1417] Value Now Compares to missingFloat Variable by ericahin · Pull Request #1441 · processing/processing4

Conversation

@ericahin

@ericahin ericahin commented Feb 19, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

✅ Title: clear and descriptive

✅ Resolves: Resolves #1417

✅ Changes: Changed the comparison on line 4822 that is checking if the float variable "value" is NaN to use the globally declared variable "missingFloat." This was labeled as a TODO. This maintains consistency throughout the document so is anything were to change, this comparison would stay consistent with the rest of the file.

✅ Tests: I created a function in TableTest.java called testGetMaxFloat() which checks all edge cases of Null, negative numbers, 0, positive numbers, etc. I also tested using the "./gradlew test" command, all tests were passed by this code

✅ Checklist: All tests pass and I have pulled/pushed the most recent changes/updates from upstream onto my branch

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ksen0 reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@ericahin
ericahin force-pushed the compare-to-missingFloat-issue branch from 02b8ddf to 9ed1143 Compare February 25, 2026 19:23
@ericahin
ericahin force-pushed the compare-to-missingFloat-issue branch from dcbca46 to 0a6d561 Compare March 9, 2026 18:10
ericahin added 2 commits March 9, 2026 14:11
@ericahin
changed value to compare to missingFloat variable
7a6399e
@ericahin
added unit tests for checking Table extreme values
1c8a1da
@ericahin
ericahin force-pushed the compare-to-missingFloat-issue branch from 0a6d561 to 1c8a1da Compare March 9, 2026 18:11
@ericahin
ericahin marked this pull request as ready for review March 9, 2026 18:12
@marksherman

marksherman commented Mar 11, 2026

Copy link
Copy Markdown

@elisefergusonn can you please review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@elisefergusonn

elisefergusonn commented Mar 16, 2026

Copy link
Copy Markdown

LGTM 👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@srnkan

srnkan commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Looks good to me too!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

catilac
catilac approved these changes Jul 8, 2026
View reviewed changes

@catilac catilac left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful! thank you so much @ericahin

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@catilac
catilac merged commit 0e0be1b into processing:main Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@catilac catilac catilac approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Check for missing value

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ericahin @marksherman @elisefergusonn @srnkan @catilac
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.