GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Lower bounds check on IntList get by smarasca5 · Pull Request #1477 · processing/processing4

Conversation

@smarasca5

@smarasca5 smarasca5 commented Mar 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Title: Lower bounds check on IntList get

Resolves #1415

Changes: Added a lower bound within the if statement of the get method within IntList. There was no lower bounds check within this method before. Now it throws exception if index is negative.

Tests: tests within IntListTest

Checklist: Tests pass and branch is up to date

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@marksherman

marksherman commented Mar 11, 2026

Copy link
Copy Markdown

We might want to squash the commits into a single commit thaat has a more descriptive name. That way there's one commit with all the small changes packed together, so looking at the history it will be clear what happened here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marksherman

marksherman commented Mar 11, 2026

Copy link
Copy Markdown

@FranciscoJ26 could you please review these changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FranciscoJ26

FranciscoJ26 commented Mar 18, 2026

Copy link
Copy Markdown

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@smarasca5
IntList get lower bounds check now enforced, test added
2ed09ee
@smarasca5
smarasca5 force-pushed the lower-bounds-check-1415 branch from 75ea3dd to 2ed09ee Compare March 23, 2026 18:40
@smarasca5

smarasca5 commented Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

newly updated! now has tests :) now ready for review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
catilac
catilac approved these changes Jul 2, 2026
View reviewed changes

@catilac catilac left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @smarasca5 @marksherman

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@catilac
catilac merged commit 7b8f4a2 into processing:main Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@catilac catilac catilac approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lower bounds checking on IntList get method

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@smarasca5 @marksherman @FranciscoJ26 @catilac
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.