GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — Gradle 9 compatibility by letorbi · Pull Request #1535 · processing/processing4 Conversation
Contributor
Currently the build process fails with Gradle 9 due to a depreciated statement in app/build.gradle.kt. The relevant part of the error message is: This PR enables Gradle 9 compatibility by replacing the Important: Even though I am pretty sure that the new statement will work, I was not able to test it on MacOS, which seems to be the only system that actually executes the modified line. This should be done by a reviewer before merging the PR.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
Ok, good to know that you are already on it. I searched for Gradle relates issues and branches before creating the PR, but didn't find anything, therefore I assumed it was fine to create the PR - I am sorry, if not. I am also not exactly a first-time contributor: Ben merged a PR from me in 2021 (b1eed96) and I am the maintainer of the Processing packages for Arch Linux since a least six years. Anyway, since I am also not exactly a regular contributor, I re-read the contribution guidelines, but I still do not really see an obvious mistake I made by creating the PR. Maybe the fact, that I was not able to test the change on a Mac or should I have created an issue before creating the PR? Could you please point me to the thing I am missing? Last question: Is there an issue regarding the Gradle 9 migration I could subscribe to? The Arch packages I maintain contain my patch right now to avoid the heavy Gradle 8 dependency, but I'd like to remove it as soon as your branch has been merged into main. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@letorbi No need to be sorry! I think it's helpful to open up an issue. The project is somewhat disorganized right now (my fault). Also I didn't realize you had contributed in the past. I think that's great. I'm happy you're here. We have been discussing gradle 9 in the discord, and it's also come up here: #1514 I wouldn't call that well documented. I'll create a proper issue, because we do want to upgrade and I need help figuring out what would break if we suddenly made that upgrade. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@letorbi merged thank you |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@catilac Thank you for merging my PR. I've also subscribed to the issue you've mentioned and joined the Discord server. See you there. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.