GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Follow up to unbreaking neobrains work by catilac · Pull Request #1555 · processing/processing4

Conversation

@catilac

@catilac catilac commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Un-breaks work @neobrain did here: 4673b6b

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@catilac

catilac commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

@neobrain could you review this? I had to change the syntax a bit, but let me know.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@neobrain

neobrain commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Hey, thanks for the follow up -- why did this need to be patched in signApp instead of zipDistributable? As-is I'm still getting the "Task with name 'createDistributable' not found in project 'app'" error since the zipDistributable task is eagerly using distributable()..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@catilac
catilac requested a review from neobrain July 29, 2026 18:36
@neobrain

neobrain commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@catilac Do you need any further information? I believe my original patch should still apply without changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
neobrain
neobrain suggested changes Jul 29, 2026
View reviewed changes

@neobrain neobrain left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@catilac

catilac commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator Author

Didn't mean to be alarming @neobrain I added you as a reviewer to see that I'm able since you've been given triage permissions. Will address your comments, haven't had a chance as of yet
neobrain reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@catilac
replaying neobrain: Use lazy evaluation for dependencies of the zipDi…
d2958d7 
…stributable task
@catilac
catilac force-pushed the one_more branch from 35ee109 to d2958d7 Compare July 31, 2026 20:36
@catilac

catilac commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

@neobrain oopsie! just moved it and re-requesting review. thanks for all your help on this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@catilac
catilac requested a review from neobrain July 31, 2026 20:36
neobrain
neobrain approved these changes Jul 31, 2026
View reviewed changes

@neobrain neobrain left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working now, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
catilac reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@catilac
catilac merged commit 3a43b70 into processing:main Aug 2, 2026
6 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@neobrain neobrain neobrain approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@catilac @neobrain
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.