GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove hard cap and honor configured retry intervals by parfeon · Pull Request #231 · pubnub/python

Conversation

@parfeon

@parfeon parfeon commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

fix(reconnection): remove hard cap and honor configured retry intervals

The retry limit was silently clamped to the policy default, configured intervals were ignored by delay calculators, and the async reconnection loop never checked the limit or advanced its counter — fix all three and add a maximum_reconnection_interval config option.

refactor(publish): remove client-side publish sequence number (seqn)

seqn is not required by PubNub REST API, so remove PublishSequenceManager, all its subclasses, MAX_SEQUENCE, and seqn injection.

test(reconnection): rewrite and expand reconnection and effect delay tests

Cover LinearDelay, ExponentialDelay, ReconnectionManager, ReconnectEffect, and HeartbeatDelayedEffect with deterministic assertions for default, custom, and edge cases

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@parfeon
fix(reconnection): remove hard cap and honor configured retry intervals
d3e1dab 
The retry limit was silently clamped to the policy default, configured intervals were ignored by
delay calculators, and the async reconnection loop never checked the limit or advanced its counter
— fix all three and add a `maximum_reconnection_interval` config option.

refactor(publish): remove client-side publish sequence number (`seqn`)

`seqn` is not required by PubNub REST API, so remove `PublishSequenceManager`, all its subclasses,
`MAX_SEQUENCE`, and `seqn` injection.

test(reconnection): rewrite and expand reconnection and effect delay tests

Cover `LinearDelay`, `ExponentialDelay`, `ReconnectionManager`, `ReconnectEffect`, and
`HeartbeatDelayedEffect` with deterministic assertions for default, custom, and edge cases
@parfeon parfeon self-assigned this Apr 19, 2026
@parfeon parfeon added status: done This issue is considered resolved. priority: high This PR should be reviewed ASAP. type: fix This PR contains fixes to existing features. type: refactor This PR contains refactored existing features. labels Apr 19, 2026
@pubnub-ops-terraform

pubnub-ops-terraform commented Apr 19, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
parfeon added 3 commits April 20, 2026 01:46
@parfeon
refactor(lint): address lint warnings
91f59aa
@parfeon
refactor(test): remove from cassettes 'seqn' from removed manager
0e568ca
@parfeon
refactor(test): fixed test to work properly for asyncio
6fc9c34
@parfeon
parfeon marked this pull request as ready for review April 20, 2026 08:16
@parfeon
parfeon requested a review from jguz-pubnub as a code owner April 20, 2026 08:16
jguz-pubnub
jguz-pubnub approved these changes Apr 20, 2026
View reviewed changes
@parfeon

parfeon commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

@pubnub-release-bot release
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pubnub-release-bot
PubNub SDK 10.6.3 release.
c592b52
@parfeon
parfeon merged commit fe0d9a3 into master Apr 20, 2026
13 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@parfeon
parfeon deleted the CLEN-3351-remove-hard-retry-maximum branch April 20, 2026 12:34
@pubnub-release-bot

pubnub-release-bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

🚀 Release successfully completed 🚀
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jguz-pubnub jguz-pubnub jguz-pubnub approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@parfeon parfeon

Labels

priority: high This PR should be reviewed ASAP. status: done This issue is considered resolved. type: fix This PR contains fixes to existing features. type: refactor This PR contains refactored existing features.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@parfeon @pubnub-ops-terraform @pubnub-release-bot @jguz-pubnub
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.