GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add HTTP/2 support and protocol version logging by jguz-pubnub · Pull Request #232 · pubnub/python

Conversation

jguz-pubnub commented May 14, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

feat: enable HTTP/2 negotiation on the synchronous httpx handler

feat: add http_version field to ResponseInfo

feat: log negotiated protocol version at DEBUG level across all request handlers

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add HTTP/2 support and protocol version logging

210f59b

- feat: enable HTTP/2 negotiation on the synchronous httpx handler
- feat: add http_version field to ResponseInfo
- feat: log negotiated protocol version at DEBUG level across all request handlers

jguz-pubnub requested a review from parfeon as a code owner

May 14, 2026 10:29

pubnub-ops-terraform commented May 14, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jguz-pubnub added 3 commits

May 14, 2026 12:33


          Fix lint errors

00ff8bf


          Merge branch 'master' into python-http2

5779bf1


          Update requirements-dev.txt

dcc3285

parfeon requested changes

May 27, 2026

View reviewed changes

Comment thread

pubnub/request_handlers/async_aiohttp.py Outdated

Comment on lines +177 to +180

		logger.debug(
		"PubNub request completed: operation=%s protocol=%s"
		% (options.operation_type, response_info.http_version)
		)

parfeon May 27, 2026

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug probably over informative, but we don't have other levels yet.
I would suggest to merge it with data log above.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

pubnub/request_handlers/async_httpx.py Outdated

Comment on lines +229 to +232

		logger.debug(
		"PubNub request completed: operation=%s protocol=%s"
		% (options.operation_type, response_info.http_version)
		)

parfeon May 27, 2026

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug probably over informative, but we don't have other levels yet.
I would suggest to merge it with data log above.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

pubnub/request_handlers/requests.py Outdated

Comment on lines +281 to +284

		logger.debug(
		"PubNub request completed: operation=%s protocol=%s"
		% (e_options.operation_type, http_ver)
		)

parfeon May 27, 2026

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we actually print it if version information available in response?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

jguz-pubnub May 27, 2026

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what I've been told to deliver:

Deliverables:

Debug logs such as:

PubNub request completed: operation=subscribe protocol=HTTP/2
PubNub request completed: operation=publish protocol=HTTP/1.1

I'll try to make it less noisy and merge it with data logs you suggested

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

parfeon May 27, 2026

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've missed operation in the format.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

requirements-dev.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

pubnub/request_handlers/httpx.py Outdated

parfeon May 27, 2026

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be instructed in a same way as AsyncClient need to specify http2=True in constructor.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

pubnub/request_handlers/async_httpx.py Outdated

parfeon May 27, 2026

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But where is http2=True in constructor?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

pubnub/request_handlers/async_aiohttp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

pubnub/request_handlers/requests.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

jguz-pubnub force-pushed the python-http2 branch from 420015f to edba4bf Compare

May 27, 2026 12:02

jguz-pubnub requested a review from parfeon

May 27, 2026 12:03

jguz-pubnub added 3 commits

May 27, 2026 14:07


          Fixes according to review

0171e57


          requirements-dev.txt

eccc6a1


          conftest.py

e44d797

parfeon approved these changes

Jun 3, 2026

View reviewed changes

parfeon left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

jguz-pubnub commented Jun 8, 2026

Copy link

Copy Markdown

Contributor Author

@pubnub-release-bot release

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          PubNub SDK 10.7.0 release.

677686f

jguz-pubnub merged commit 7ecb2b0 into master

Jun 9, 2026

17 of 34 checks passed

Uh oh!

There was an error while loading. Please reload this page.

jguz-pubnub deleted the python-http2 branch

June 9, 2026 08:45

pubnub-release-bot commented Jun 9, 2026

Copy link

Copy Markdown

Contributor

🚀 Release successfully completed 🚀

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jguz-pubnub mentioned this pull request

Jun 11, 2026

Remove negotiated HTTP version from DEBUG logs #233

Closed

Reviewers

parfeon

parfeon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

jguz-pubnub commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pubnub-ops-terraform commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

parfeon left a comment

Choose a reason for hiding this comment

Uh oh!

jguz-pubnub commented Jun 8, 2026

Uh oh!

Uh oh!

pubnub-release-bot commented Jun 9, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jguz-pubnub commented May 14, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

pubnub-ops-terraform commented May 14, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.