GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Migrate to GitHub Actions by thomashoneyman · Pull Request #38 · purescript-node/purescript-node-buffer

Conversation

@thomashoneyman

@thomashoneyman thomashoneyman commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

This PR migrates node-buffer to use GitHub Actions instead of Travis for CI, as tracked for all core libraries in purescript/purescript#3962. It also updates the installation instructions to refer to Spago instead of Bower and adds a Pursuit link.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thomashoneyman
Migrate to GitHub Actions and update installation instructions.
c881921
@thomashoneyman thomashoneyman mentioned this pull request Dec 9, 2020
Core library updates for 0.14 purescript/purescript#3942
Closed
57 tasks done
thomashoneyman added 2 commits December 9, 2020 12:00
@thomashoneyman
Update ci.yml
e36d38c
@thomashoneyman
Apply eslint suggestions
b37ddff
JordanMartinez
JordanMartinez approved these changes Dec 9, 2020
View reviewed changes
Comment thread src/Node/Buffer/Internal.js
buf['write' + ty](value, offset);
return function () {
buf["write" + ty](value, offset);
return {};

@JordanMartinez JordanMartinez Dec 9, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to return {} anymore for unit, correct?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/Node/Buffer/Internal.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@thomashoneyman
thomashoneyman merged commit 37107a7 into master Dec 9, 2020
@thomashoneyman
thomashoneyman deleted the github-actions branch December 9, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JordanMartinez JordanMartinez JordanMartinez approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@thomashoneyman @JordanMartinez
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.