GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Don't return empty object for unit by thomashoneyman · Pull Request #40 · purescript-node/purescript-node-buffer

Conversation

@thomashoneyman

@thomashoneyman thomashoneyman commented Dec 10, 2020

Copy link
Copy Markdown
Contributor

This change removes return {} from functions which return no useful value (Unit), for a small performance benefit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thomashoneyman
Don't return empty object for unit
a4ec3c8
kl0tl
kl0tl approved these changes Dec 10, 2020
View reviewed changes
@thomashoneyman
thomashoneyman merged commit bee0b99 into master Dec 10, 2020
@thomashoneyman
thomashoneyman deleted the no-empty-object-return branch December 10, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kl0tl kl0tl kl0tl approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@thomashoneyman @kl0tl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.