GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Base64Url encoding by JordanMartinez · Pull Request #56 · purescript-node/purescript-node-buffer

Conversation

@JordanMartinez

@JordanMartinez JordanMartinez commented Jul 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Description of the change

  • Add Base64Url encoding.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JordanMartinez added 2 commits July 5, 2023 10:59
@JordanMartinez
Add Base64Url encoding
a716d68
@JordanMartinez
Drop aliased encodings
e8fe84c
@JordanMartinez JordanMartinez changed the title update encoding Add Base64Url encoding; drop aliased encodings Jul 5, 2023
@JordanMartinez

JordanMartinez commented Jul 5, 2023

Copy link
Copy Markdown
Contributor Author

@thomashoneyman 🏓
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thomashoneyman

thomashoneyman commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

Has Node indicated that they will drop these aliases? What harm do you see in retaining them?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JordanMartinez

JordanMartinez commented Jul 5, 2023

Copy link
Copy Markdown
Contributor Author

Has Node indicated that they will drop these aliases? What harm do you see in retaining them?

The UCS2 one not so much, but the binary one is confusing. Per Node docs

'binary': Alias for 'latin1'. See binary strings for more background on this topic. The name of this encoding can be very misleading, as all of the encodings listed here convert between strings and binary data (emphasis mine). For converting between strings and Buffers, typically 'utf8' is the right choice.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JordanMartinez

JordanMartinez commented Jul 5, 2023

Copy link
Copy Markdown
Contributor Author

Regardless, this is one of those "controversial" changes, and I don't want to be blocked by this. I'll revert the commit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JordanMartinez
Revert "Drop aliased encodings"
bb0870d 
This reverts commit e8fe84c.
@JordanMartinez JordanMartinez changed the title Add Base64Url encoding; drop aliased encodings Add Base64Url encoding Jul 5, 2023
thomashoneyman
thomashoneyman approved these changes Jul 5, 2023
View reviewed changes
@JordanMartinez
JordanMartinez merged commit c447cb5 into master Jul 5, 2023
@JordanMartinez
JordanMartinez deleted the update-encoding branch July 5, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JordanMartinez @thomashoneyman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.